Closed Bug 1726275 Opened 1 year ago Closed 9 months ago

Update audioipc to pick up IPC rework

Categories

(Core :: Audio/Video: cubeb, task)

task

Tracking

()

RESOLVED FIXED
97 Branch
Tracking Status
firefox97 --- fixed

People

(Reporter: kinetik, Assigned: kinetik)

References

(Blocks 3 open bugs)

Details

Attachments

(3 files)

Tracking bug for landing IPC rework and fixes to enable pref-on for macOS (Windows and Linux will be switched over after some initial testing on macOS).

Blocks: 1726279
Blocks: 1425788
Blocks: 1697845
Attached file GitHub Pull Request
Depends on: 1743740
Attached file GitHub Pull Request
Attachment #9253149 - Attachment description: WIP: Bug 1726275 - Update audioipc to pick up IPC rework. → Bug 1726275 - Update audioipc to pick up IPC rework. r?chunmin
Attachment #9253149 - Attachment description: Bug 1726275 - Update audioipc to pick up IPC rework. r?chunmin → Bug 1726275 - Update AudioIPC to pick up IPC rework. r?chunmin
Attachment #9253149 - Attachment description: Bug 1726275 - Update AudioIPC to pick up IPC rework. r?chunmin → Bug 1726275 - Update AudioIPC to pick up IPC rework. r=chunmin
Pushed by mgregan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/736011c1640c
Update AudioIPC to pick up IPC rework. r=chunmin

Backed out changeset 736011c1640c (Bug 1726275) for causing build bustages.
Backout link
Push with failures
Failure Log

Flags: needinfo?(kinetik)

The build failure was caused by cargo trying to clone both of the master and macos audioipc-2 branches into the same git repo. I didn't hit that locally or on try because I was still testing with the version of the changeset that pointed the macos branch at my own repo. I've reverted to that solution for now, so https://github.com/kinetiknz/audioipc-2/tree/macos is identical to https://github.com/mozilla/audioipc-2/tree/macos.

Flags: needinfo?(kinetik)
Pushed by mgregan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c616e11bb8be
Update AudioIPC to pick up IPC rework. r=chunmin

Looks like the landing will stick this time. Note that this feature is not enabled yet; the media.cubeb.sandbox thread can be flipped to true (Firefox restart required) for testing. Enabling by default is tracked in bug 1425788.

what's different between ashmem 0.1.1 and your fork?

Flags: needinfo?(kinetik)

Answering my own question: no substantial difference (and it's not a fork, it's upstream). Can you update audioipc so that it depends on ashmem from crates.io rather than your github repo?

Blocks: 1746352

Will do in bug 1746352. Thanks for the ping.

Flags: needinfo?(kinetik)
Target Milestone: --- → 97 Branch
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED

That busted building with versions older than 1.57.0:

Compiling audioipc2-client v0.5.0 (https://github.com/kinetiknz/audioipc-2?rev=abd4a0132ea65057b554221c8f112a9bedd33a92#abd4a013)
error[E0658]: use of unstable library feature 'try_reserve': new API

which wasn't caught by CI because we only test rustc < 1.57 on Linux. You're in luck that we were actually planning for an update of the requirement for just now.

Depends on: 1744234
Blocks: 1746689
Blocks: 1747213
Blocks: 1700243
Blocks: 1748037
Blocks: 1748160
Blocks: 1748515
Blocks: 1757473
You need to log in before you can comment on or make changes to this bug.