1726275 - Update audioipc to pick up IPC rework

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, task)

Description

[Matthew Gregan [:kinetik]]

Tracking bug for landing IPC rework and fixes to enable pref-on for macOS (Windows and Linux will be switched over after some initial testing on macOS).

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: GitHub Pull Request

Comment 2

[Matthew Gregan [:kinetik]]

Attachment: Bug 1726275 - Update AudioIPC to pick up IPC rework. r=chunmin

Depends on D132537

Comment 3

[Matthew Gregan [:kinetik]]

Attachment: GitHub Pull Request

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/736011c1640c
Update AudioIPC to pick up IPC rework. r=chunmin

Comment 5

[Marian-Vasile Laza]

Backed out changeset 736011c1640c (Bug 1726275) for causing build bustages.
Backout link
Push with failures
Failure Log

Comment 6

[Matthew Gregan [:kinetik]]

The build failure was caused by cargo trying to clone both of the master and macos audioipc-2 branches into the same git repo. I didn't hit that locally or on try because I was still testing with the version of the changeset that pointed the macos branch at my own repo. I've reverted to that solution for now, so https://github.com/kinetiknz/audioipc-2/tree/macos is identical to https://github.com/mozilla/audioipc-2/tree/macos.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c616e11bb8be
Update AudioIPC to pick up IPC rework. r=chunmin

Comment 8

[Matthew Gregan [:kinetik]]

Looks like the landing will stick this time. Note that this feature is not enabled yet; the media.cubeb.sandbox thread can be flipped to true (Firefox restart required) for testing. Enabling by default is tracked in bug 1425788.

Comment 9

[Mike Hommey [:glandium]]

what's different between ashmem 0.1.1 and your fork?

Comment 10

[Mike Hommey [:glandium]]

Answering my own question: no substantial difference (and it's not a fork, it's upstream). Can you update audioipc so that it depends on ashmem from crates.io rather than your github repo?

Comment 11

[Matthew Gregan [:kinetik]]

Will do in bug 1746352. Thanks for the ping.

Comment 12

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c616e11bb8be

Comment 13

[Mike Hommey [:glandium]]

That busted building with versions older than 1.57.0:

Compiling audioipc2-client v0.5.0 (https://github.com/kinetiknz/audioipc-2?rev=abd4a0132ea65057b554221c8f112a9bedd33a92#abd4a013)
error[E0658]: use of unstable library feature 'try_reserve': new API

which wasn't caught by CI because we only test rustc < 1.57 on Linux. You're in luck that we were actually planning for an update of the requirement for just now.