Closed Bug 1726344 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 30068 - Make canvas filter input a flat dictionary

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
93 Branch
Tracking Flags:
Tracking Status
firefox93 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30068 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30068
Details from upstream follow.

b'Aaron Krajeski <aaronhk@chromium.org>' wrote:

Make canvas filter input a flat dictionary

As initially specced, CanvasFilter inputs had a single key that was the
name of the filter:

ctx.filter = new CanvasFilter({gaussianBlur: {stdDeviation: 5}});

As the result of the debate here
(https://github.com/whatwg/html/pull/6763) the interface is changed to
have a "filter" key that names the filter type:

ctx.filter = new CanvasFilter(
{filter: "gaussianBlur", stdDeviation: 5}});

Bug: 1169216
Change-Id: If3fdd9185c1f02dd2dece7db0c92aba76f2d97e1

Reviewed-on: https://chromium-review.googlesource.com/3098009
WPT-Export-Revision: 2ab685b2a1de6718ecf32f56ccd1e7adb53df7ae

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 30 tests and 1 subtests

Status Summary

Firefox

OK : 27
FAIL: 30

Chrome

OK : 27
PASS: 6
FAIL: 24

Safari

OK : 27
FAIL: 30

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/canvas/element/manual/filters/canvas-filter-object-blur.html: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/element/manual/filters/canvas-filter-object-component-transfer.html: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/element/manual/filters/canvas-filter-object-convolve-matrix.html: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/filters/2d.filter.canvasFilterObject.blur.exceptions.html
Test exceptions on CanvasFilter() blur.object: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/element/filters/2d.filter.canvasFilterObject.blur.exceptions.html
Test exceptions on CanvasFilter() blur.object: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/filters/2d.filter.canvasFilterObject.blur.exceptions.worker.html
Test exceptions on CanvasFilter() blur.object: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/element/filters/2d.filter.canvasFilterObject.colorMatrix.html
Test the functionality of ColorMatrix filters in CanvasFilter objects: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/filters/2d.filter.canvasFilterObject.colorMatrix.html
Test the functionality of ColorMatrix filters in CanvasFilter objects: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/element/filters/2d.filter.canvasFilterObject.componentTransfer.discrete.html
Test pixels on CanvasFilter() componentTransfer with discrete type: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/filters/2d.filter.canvasFilterObject.colorMatrix.worker.html
Test the functionality of ColorMatrix filters in CanvasFilter objects: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/element/filters/2d.filter.canvasFilterObject.componentTransfer.gamma.html
Test pixels on CanvasFilter() componentTransfer with gamma type: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/filters/2d.filter.canvasFilterObject.componentTransfer.discrete.html
Test pixels on CanvasFilter() componentTransfer with discrete type: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/element/filters/2d.filter.canvasFilterObject.componentTransfer.identity.html
Test pixels on CanvasFilter() componentTransfer with identity type: FAIL (Chrome: PASS, Safari: FAIL)
/html/canvas/offscreen/filters/2d.filter.canvasFilterObject.componentTransfer.discrete.worker.html
Test pixels on CanvasFilter() componentTransfer with discrete type: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/element/filters/2d.filter.canvasFilterObject.componentTransfer.linear.html
Test pixels on CanvasFilter() componentTransfer with linear type: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/filters/2d.filter.canvasFilterObject.componentTransfer.gamma.html
Test pixels on CanvasFilter() componentTransfer with gamma type: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/element/filters/2d.filter.canvasFilterObject.componentTransfer.table.html
Test pixels on CanvasFilter() componentTransfer with table type: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/filters/2d.filter.canvasFilterObject.componentTransfer.gamma.worker.html
Test pixels on CanvasFilter() componentTransfer with gamma type: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/element/filters/2d.filter.canvasFilterObject.convolveMatrix.exceptions.html
Test exceptions on CanvasFilter() convolveMatrix: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/filters/2d.filter.canvasFilterObject.componentTransfer.identity.html
Test pixels on CanvasFilter() componentTransfer with identity type: FAIL (Chrome: PASS, Safari: FAIL)
/html/canvas/element/filters/2d.filter.canvasFilterObject.html
Test CanvasFilter() object: FAIL (Chrome: PASS, Safari: FAIL)
/html/canvas/offscreen/filters/2d.filter.canvasFilterObject.componentTransfer.identity.worker.html
Test pixels on CanvasFilter() componentTransfer with identity type: FAIL (Chrome: PASS, Safari: FAIL)
/html/canvas/offscreen/filters/2d.filter.canvasFilterObject.componentTransfer.linear.html
Test pixels on CanvasFilter() componentTransfer with linear type: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/filters/2d.filter.canvasFilterObject.componentTransfer.linear.worker.html
Test pixels on CanvasFilter() componentTransfer with linear type: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/filters/2d.filter.canvasFilterObject.componentTransfer.table.html
Test pixels on CanvasFilter() componentTransfer with table type: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/filters/2d.filter.canvasFilterObject.componentTransfer.table.worker.html
Test pixels on CanvasFilter() componentTransfer with table type: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/filters/2d.filter.canvasFilterObject.convolveMatrix.exceptions.html
Test exceptions on CanvasFilter() convolveMatrix: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/filters/2d.filter.canvasFilterObject.convolveMatrix.exceptions.worker.html
Test exceptions on CanvasFilter() convolveMatrix: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/filters/2d.filter.canvasFilterObject.html
Test CanvasFilter() object: FAIL (Chrome: PASS, Safari: FAIL)
/html/canvas/offscreen/filters/2d.filter.canvasFilterObject.worker.html
Test CanvasFilter() object: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f2bef1e16aba [wpt PR 30068] - Make canvas filter input a flat dictionary, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f2bef1e16aba

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox93: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.