Closed Bug 1726384 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30074 - <dialog> with display:contents should get display:block

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
93 Branch
Tracking Flags:
Tracking Status
firefox93 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30074 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30074
Details from upstream follow.

b'Mason Freed <masonf@chromium.org>' wrote:

<dialog> with display:contents should get display:block

The existing test shows that Chromium's current behavior does
not comply with the spec [1]. If a fullscreen element (which
an open \<dialog> is) or its ::backdrop pseudo-element is
display:contents, then it should compute to display:block.

[1] https://fullscreen.spec.whatwg.org/#new-stacking-layer

Fixed: 1240701
Change-Id: Id83a45d5eafa84d9a40ef9286b010e07c6408a4b
Reviewed-on: https://chromium-review.googlesource.com/3102297
WPT-Export-Revision: c8b9aadf3360b9da71259db0572b090385478e84

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INVALID
PR 30074 applied with additional changes from upstream: 344ef27751b2c38a91fc675c5c1f9be64869bc39
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/interactive-elements/the-dialog-element/modal-dialog-display-contents.html: FAIL (Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4813cd7ad432
[wpt PR 30074] - <dialog> with display:contents should get display:block, a=testonly

https://hg.mozilla.org/mozilla-central/rev/4813cd7ad432

Status: REOPENED → RESOLVED
Closed: 3 years ago → 3 years ago
status-firefox93: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.