1726430 - Generated visual studio solution and projects give intellisense warnings for C++17 features

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P3)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

When working with the generated VisualStudio files for mozilla-central, VisualStudio seems to prefer the C++14 standard for intellisense. This results in it generating warnings and red squigglies for things like

• std library features only available in C++17
• nested name spaces, e.g. namspace mozilla::media
• inline usage on variables

This isn't a big problem, but it would be nice to have VisualStudio recognize C++17 code.

If I create a solution in VisualStudio 2019 I can navigate to the Properties -> General page for the solution and change the standard version used. However this isn't available for my Moz generated projects.

FWIW, toggling the standard version on a project seems to set something like the following in the project file

<LanguageStandard>stdcpp17</LanguageStandard>

Is it possible to set the standard in the generated files?

Comment 1

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 1726430 - Updated Visual Studio project file generation to set C++17 as the language standard for IntelliSense by adding /std:c++17 to <AdditionalOptions> for all projects. r?mhentges

Comment 2

[Alex Hochheiden [:ahochheiden] [he/him]]

Adding the <LanguageStandard> field and playing around with the values did not work for me.

Adding /std:c++17 to <AdditionalOptions> under the NMake project properties made IntelliSense use C++17 for my testing. (No red squiggles warnings for C++17 style nested namespaces eg: namspace mozilla::media{};)

I've submitted a patch that adds the /std:c++17 value for <AdditionalOptions> on VS Project Generation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdfd88ac2490
Updated Visual Studio project file generation to set C++17 as the language standard for IntelliSense by adding /std:c++17 to <AdditionalOptions> for all projects. r=mhentges

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/bdfd88ac2490