Theme pinned tab notification dot
Categories
(Firefox :: Theme, enhancement, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: bugzilla, Assigned: bugzilla, NeedInfo)
References
Details
(Whiteboard: [fidefe-theme])
Attachments
(1 file)
The new themes should theme the dot that appears under updated pinned tabs. This isn't something that needs to be exposed to third party themes. We can theme it with theme_experiment, similar to how we theme the app menu update badge.
|
Assignee | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
This is just a matter of setting --attention-icon-color in theme_experiment.
|
|
Assignee | |
Comment 3•3 years ago
|
||
The new attribute on :root is necessary because theme_experiment sets variables on :root. --icon-attention-color was being set on #TabsToolbar, meaning it was more specific and the theme override was not applying.
|
|
Assignee | |
Updated•3 years ago
|
Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/06d6b39b2638 Theme pinned tab notification dot. r=dao
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
|
||
Comment 6•3 years ago
|
||
I can still reproduce this on warning icons:
- Warning Alerts - Soft Themes
- Critical Alerts - Bold and Balanced Themes
And this is reproducing across all platforms. Should we log another issue or this can be tracked here?
|
|
Assignee | |
Comment 7•3 years ago
|
||
Yes, we decided in review not to theme warning icons so that they have a consistent look that users can consistently identify. How do you trigger a critical alert?
|
|
||
Comment 8•3 years ago
|
||
(In reply to Harry Twyford [:harry] from comment #7)
How do you trigger a critical alert?
We use this test page.
From the sections "Desktop Download Warnings" download the link from 7.
Yes, we decided in review not to theme warning icons so that they have a consistent look that users can consistently identify.
I understand. The only problem is that the notification is harder to see when using darker themes and especially while using Foto and Abstract.
|
|
Assignee | |
Comment 9•3 years ago
|
||
Dao, how do you think we should balance a consistent look for warning icons vs. legibility in themes?
|
||
Comment 10•2 years ago
|
||
The contrast on the warning notification icons (similar to comment 8) is still problematic on some of the new 97 colorway themes - see example. Note there is a new implementation since last time that set alwaysOpenPanel default on any download, so the warning badges for the end users (as in the mentioned example) are visible only if browser.download.alwaysOpenPanel is set to false. Should we fill a new issue specific for the new 97 themes?
Description
•