1726474 - Enable wasm sandboxing on 64-bits Windows

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1726474 - Preload rlbox library on Windows.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1726474 - Remove unrelevant flags from wasm builds.

RTL flags are flags that chooses which C/C++ runtime library to use
(multi-threaded, debug, etc.). They're only relevant when targeting
Windows, not when targeting wasi.

Frame pointer flags are not relevant to wasm (as a matter of fact,
the same wasm code is generated whether using -fomit-frame-pointer
or -fno-omit-frame-pointer)

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1726474 - Always use clang-type flags when targeting wasm.

The build system assumes the target compiler is of the same type as the
wasm compiler, but that's not true for wasm32-wasi, which we compile
with clang, while targeting windows, which we compile with clang-cl.
We handle the duality for host/target in a compiler-specific way, but
here, the wasm compiler is always going to be clang.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1726474 - Enable wasm sandboxing on 64-bits Windows.

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for multiple crashes.

• backout: https://hg.mozilla.org/integration/autoland/rev/e0309c1ae0fe14ab9a30270fce542cfd4de08849

• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=5add6784a7844db35660b2b7554d1c4c6d9e7ba2&selectedTaskRun=DecVtrwWQV6BP-isApHl4A.0

• failure logs:
  *REFTEST PROCESS-CRASH | pid: None | application crashed [@ mozilla::dom::ContentChild::RecvSetProcessSandbox(mozilla::Maybe<mozilla::ipc::FileDescriptor> const&)]
  *PROCESS-CRASH | marionette.py | application crashed [@ XUL + 0x2846f7b]

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out for causing windows build bustages.

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=c7fcc6914b7cb3a216fe0e0d18a4d1ae10d0f4c7&selectedTaskRun=Lcjeuq8sRgKvEnqJbnxUgQ.0

Failure logs:

• https://treeherder.mozilla.org/logviewer?job_id=349341835&repo=autoland
• https://treeherder.mozilla.org/logviewer?job_id=349341864&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/2cb2d3457a50fc88fb24f54858c3c99678811e44

Comment 7

[Mike Hommey [:glandium]]

Attachment: Bug 1726474 - Enable wasm32-wasi support on clang-mingw toolchains.

Comment 8

[Alexandru Michis [:malexandru]]

glandium, could these clang-format bustages that have appeared on try be caused by your changes?

Comment 9

[Mike Hommey [:glandium]]

Attachment: Bug 1726474 - Set IMPORT_LIBRARY when building WASM_LIBRARY.

MKCSHLIB, used to build WASM_LIBRARY, refers to DSO_LDOPTS, which refers
to IMPORT_LIBRARY on mingw builds, but for WASM_LIBRARY, IMPORT_LIBRARY
is never set by the build backend.

Comment 10

[Mike Hommey [:glandium]]

Attachment: Bug 1726474 - Update rlbox_wasm2c_sandbox and wasm2c_sandbox_compiler for mingw builds.

Comment 11

[Mike Hommey [:glandium]]

(In reply to Alexandru Michis [:malexandru] from comment #8)

glandium, could these clang-format bustages that have appeared on try be caused by your changes?

clang-format bustages are bug 1726623

Comment 12

[Mike Hommey [:glandium]]

Attachment: Bug 1726474 - Use clang.exe to build wasm files when the clang plugin is enabled.

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/57c71115a1f4
https://hg.mozilla.org/mozilla-central/rev/773a665c0383
https://hg.mozilla.org/mozilla-central/rev/7b148be964f0
https://hg.mozilla.org/mozilla-central/rev/b71fd68e042d
https://hg.mozilla.org/mozilla-central/rev/bf13adfe9000
https://hg.mozilla.org/mozilla-central/rev/b8f32a6925a6
https://hg.mozilla.org/mozilla-central/rev/a2b7afb35bb9
https://hg.mozilla.org/mozilla-central/rev/24648ecd582b

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/796a54dcb5f0
Preload rlbox library on all platforms. r=nika
https://hg.mozilla.org/integration/autoland/rev/d53f62933fd0
Remove unrelevant flags from wasm builds. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/e2047ab95703
Always use clang-type flags when targeting wasm. r=firefox-build-system-reviewers,mhentges

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e12c90f66a6c
Preload rlbox library on Windows. r=nika
https://hg.mozilla.org/integration/autoland/rev/938043bb1ca2
Remove unrelevant flags from wasm builds. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/1dcd8069568e
Always use clang-type flags when targeting wasm. r=firefox-build-system-reviewers,mhentges