172650 - Desktop shortcuts to pages cannot be created when <title> is missing

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Duane Chamblee]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.2b) Gecko/20021002
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.2b) Gecko/20021002

This URL doesn't contain a <title> tag:

http://www.nbsoftware.de/

So when I try to drag the URL icon (from the URL entry line) to the desktop, it
is not allowed. The icon changes to "cannot drop" when hovering over any desktop
folder.
M.Kaply has identified that the <title> tag is missing and it is causing this.


Reproducible: Always

Steps to Reproduce:
1. go to http://www.nbsoftware.de/
2. drag the URL line icon to the desktop
3. attempt to drop (will not work)

Actual Results:  
URL object cannot be created.

Expected Results:  
If no title, use the URL address for the object/icon title instead.

Comment 1

[Mike Kaply [:mkaply]]

I can fix this on OS/2

Comment 2

[Mike Kaply [:mkaply]]

Fix:

Index: nsDragService.cpp
===================================================================
RCS file: /cvsroot/mozilla/widget/src/os2/nsDragService.cpp,v
retrieving revision 1.22
diff -u -r1.22 nsDragService.cpp
--- nsDragService.cpp   3 Sep 2002 23:35:58 -0000       1.22
+++ nsDragService.cpp   9 Oct 2002 02:40:44 -0000
@@ -134,7 +134,10 @@
         {
           holder.Left(url, lineIndex);
           holder.Mid ( linkName, lineIndex + 1, (len/2) - (lineIndex + 1) );
-          dragitem.hstrTargetName = DrgAddStrHandle(ToNewCString(linkName));
+          if (linkName.Length() > 0)
+            dragitem.hstrTargetName = DrgAddStrHandle(ToNewCString(linkName));
+          else
+            dragitem.hstrTargetName = DrgAddStrHandle(ToNewCString(url));
           dragitem.hstrSourceName = DrgAddStrHandle(ToNewCString(url));
         }


Checked in.,

Comment 3

[Mike Kaply [:mkaply]]

Marking this verified. I tested it, and it works.

Comment 4

[Duane Chamblee]

Confirmed with nightly Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.2b)
Gecko/20021016