1726547 - Policies cannot disable VPN promo on about:privatebrowsing

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, defect)

Description

[Kestrel]

Bug 1501367 Comment 1 mentions that the policy for disabling VPN advertising is DisableFirefoxStudies but it does not work for the "Try Mozilla VPN" button on about:privatebrowsing (Bug 1659956). UserMessaging sounds like a more appropriate policy though, described as "Don't show certain messages to the user" and specifically FeatureRecommendations, described as "don't recommend browser features".

Comment 1

[Mike Kaply [:mkaply]]

The reason DisableFirefox Studies was referenced in that other bug is because at that time, we were running a study to show that messaging, so it was controlled by that policy.

For other VPN messaging, we've made it so it doesn't display at all if there is any policy. We should do the same with that Try Mozilla VPN link.

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Bug 1726547 - Don't show VPN promo link if enterprise policy is active. r?groovecoder!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4a09953de39
Don't show VPN promo link if enterprise policy is active. r=groovecoder

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/d4a09953de39

Comment 5

[Mike Kaply [:mkaply]]

Comment on attachment 9237043 [details]
Bug 1726547 - Don't show VPN promo link if enterprise policy is active. r?groovecoder!

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Specifically related to enterprises (not offering VPN)
• User impact if declined: VPN promo presented to enterprise users
• Fix Landed on Version: 93
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Isolated code, has been in tree for a while. small patch
• String or UUID changes made by this patch:

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9237043 [details]
Bug 1726547 - Don't show VPN promo link if enterprise policy is active. r?groovecoder!

Approved for 91.2esr.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/94feed72e138