1726550 - "Try Mozilla VPN" button on about:privatebrowsing has low contrast when hovered in dark mode

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[Kestrel]

Attachment: VPN button lacks contrast when hovered

STR.

1. Enable the Dark theme.
2. Open a private window.
3. Hover cursor over the "Try Mozilla VPN" button.

The button text is light instead of dark making it difficult to read.

Comment 1

[Emily McMinn :emcminn]

Attachment: Bug 1726550 - Fix hover style for about:privatebrowsing primary button; both regular and HCM

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/909bf2399362
Fix hover style for about:privatebrowsing primary button; both regular and HCM r=pdahiya

Comment 3

[Marian-Vasile Laza]

Backed out changeset 909bf2399362 (Bug 1726550) for causing bc failures on browser_contextmenu.js.
Backout link
Push with failures - bc1
Failure Log

Comment 4

[Emily McMinn :emcminn]

Hi! I'm re-running a try build to make sure, but as far as I can tell these look like intermittent failures in the context menus, and shouldn't be related to the changes in this patch (CSS only.)

Comment 5

[Emily McMinn :emcminn]

Failures in browser_contextmenu.js are passing in a more recent build:

https://treeherder.mozilla.org/jobs?repo=try&revision=ecc11fed3c1933a07c93225fc5d217705043a86e

There are some other intermittents, but they all have bugs open for them so I believe they are similarly unrelated. We'll try landing this again!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e654aefa6b84
Fix hover style for about:privatebrowsing primary button; both regular and HCM r=pdahiya

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e654aefa6b84

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emcminn, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

This appears to fix some button rendering issues in the PDF viewer (see bug 1723924). Given the trivial nature of the fix (and it grafting cleanly to ESR), what are your thoughts about an ESR uplift request?

Comment 10

[Emily McMinn :emcminn]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #9)

This appears to fix some button rendering issues in the PDF viewer (see bug 1723924). Given the trivial nature of the fix (and it grafting cleanly to ESR), what are your thoughts about an ESR uplift request?

That sounds fine to me! I can write the request today; is there anything special needed for ESR (compared to beta for ex)?

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Nope, just follow the questions on the form like usual.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Nevermind on this, we found a much more plausible candidate for what fixed that bug.

Comment 13

[Emily McMinn :emcminn]

Comment on attachment 9242140 [details]
Bug 1726550 - Fix hover style for about:privatebrowsing primary button; both regular and HCM

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Fixes some button rendering issues in the PDF viewer (see bug 1723924).
• User impact if declined: PDF viewer zoom controls disappear when hovered
• Fix Landed on Version: 94
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small CSS-only fix.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9242140 [details]
Bug 1726550 - Fix hover style for about:privatebrowsing primary button; both regular and HCM

Sorry for the false alarm here. Turns out this was unrelated to the PDF viewer bug.