1726559 - In account setup disabled buttons can sometime still change the background colour

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

The "Continue" button is normally disabled, no hover change. But when the password field has some value it can change the background colour. This comes because initially the button has disabled="disabled" and after the PW-field change only disabled="". Then the CSS rule does no more correctly apply.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1726559-button-disabled.patch

We need to split the selectors between XUL and HTML namespaces because only a check for [disabled] could cause undesired side effects with XUL buttons that are no more disabled because of the removed "true". For HTML buttons only the [disabled] selector is important for the state.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9237037 [details] [diff] [review]
1726559-button-disabled.patch

Review of attachment 9237037 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/65aaac3b0c7c
Split some button selectors to html and xul namespaces. r=aleca

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 9237037 [details] [diff] [review]
1726559-button-disabled.patch

[Approval Request Comment]
User impact if declined: in account creation disabled button can give hover feedback
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): should be low

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9237037 [details] [diff] [review]
1726559-button-disabled.patch

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 92.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/98052415bf5e

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9237037 [details] [diff] [review]
1726559-button-disabled.patch

[Triage Comment]
Approved for esr91

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 91.1.0:
https://hg.mozilla.org/releases/comm-esr91/rev/68026a7d4959