1726615 - Reorder includes in gmp-clearkey

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, task, P2)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Reorder the includes in the clearkey CDM to conform to https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

If we consider clearkey and the psshparser separate projects from one another and gecko will alter include order. For the purpose of this work I'm going to treat them all as one project.

Comment 2

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

However it makes sense to me to treat nss and the CDM headers as other projects for the purpose of ordering. Both live outside mozilla-central/mozilla-unified.

Comment 3

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1726615 - Reorder includes in ClearKey files. r?alwu

Reorder includes to match Google C++ style. The follow decisions were made to
resolve ambiguities.

• The pssh parser and clearkey are considered part of mozilla-central/Gecko and
  so have their includes grouped into the 'your project' includes at the end of
  includes. I.e. they're grouped with other mozilla-central headers.
• NSS and the CDM headers are considered as coming from other libs, so are
  placed in a block preceding the mozilla-central's.

I think everything else is decided by using the style guide and by Mozilla using
case sensitive sorting.

This also changes a few instances of using "systemheader.h" to <systemheader.h>,
which is more in line with the style guide.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2dd8cac69da5
Reorder includes in ClearKey files. r=alwu

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/2dd8cac69da5