Closed Bug 1726628 Opened 4 months ago Closed 3 months ago

Switch root Cargo toml to resolver=2

Categories

(Firefox Build System :: General, task)

task

Tracking

(firefox93 fixed)

RESOLVED FIXED
93 Branch
Tracking Status
firefox93 --- fixed

People

(Reporter: kvark, Assigned: kvark)

References

Details

Attachments

(1 file)

This is required for bug 1726626 and will be the default in 2021, which is happening soon.
At this point, there should be no risk in enabling it.

Assignee: nobody → dmalyshau
Status: NEW → ASSIGNED

This is currently blocked on the fact that gkrust_features specifies some of the features we aren't testing in any crates. Resolver=2 doesn't like this. Trying to figure out why we aren't just running all the unit tests. Bug 1457524 hints on this being desirable:

Right now we run the stylo unit tests but nothing else, via [1] and [2]. We should fix this to run all the unit tests we want to avoid breaking.

Honestly it's not obvious to me if there are unit tests we'd be fine breaking.

See Also: → 1457524

OTOH, we don't necessarily want to run tests for all third party crates, which --workspace does AIUI.
Why is this blocking bug 1726626 in the first place?

Pushed by dmalyshau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/86d44d84b2ca
Switch cargo resolver to 2 r=glandium
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.