Closed Bug 1726650 Opened 4 months ago Closed 3 months ago

[wpt-sync] Sync PR 30096 - Reland "Refactor XR mojo API to directly send array of views"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox93 fixed)

RESOLVED FIXED
93 Branch
Tracking Status
firefox93 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30096 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30096
Details from upstream follow.

b'Patrick To <patrto@microsoft.com>' wrote:

Reland "Refactor XR mojo API to directly send array of views"

This is a reland of 6aa36ea5b2abd250d763a94016235441b3c9c823.

In addition to the original change, this fixes XRViewTest.ViewMatrices.
This test creates an XRViewData on the stack and passes it into XRView
to be stored as a Member. An assertion was firing because Member expects
the object to be on the heap.

Original change's description:

Refactor XR mojo API to directly send array of views

This change sends the array of views directly from the XR process to
Blink and the browser process, instead of sending individual
head-from-eye and head-from-local poses. With this change, Blink
and the browser process no longer have to manually calculate the
transforms and can instead use the transforms directly from the XR
runtime. This also allows the XR runtime to send an arbitrary number
of views in the case where WebXR requests secondary views.

This change also improves OpenXR stability. Requesting head-from-eye
and head-from-local poses requires two separate calls to OpenXR,
which uses slightly different timestamps. As a result, the final
transform calculated by Blink and passed to WebXR is slightly off
from the transform OpenXR use, resulting in some jittering in
certain devices.

Change-Id: I5da254537ce1317e43677863aeeb6c0f234957f8
Bug: 998146
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2977592
Commit-Queue: Patrick To \<patrto@microsoft.com>
Reviewed-by: Sam McNally \<sammc@chromium.org>
Reviewed-by: Alexander Cooper \<alcooper@chromium.org>
Cr-Commit-Position: refs/heads/main@{#913173}

Bug: 998146
Change-Id: If2cd35820b94ef81a0f6fb02783c88e0c6988ac2
Reviewed-on: https://chromium-review.googlesource.com/3107853
WPT-Export-Revision: efeb5244d58257325580c69c5e0209152be7750f

Test result changes from PR not available.
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/652bf5e3d692
[wpt PR 30096] - Reland "Refactor XR mojo API to directly send array of views", a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.