172678 - The internal functions InitCRLCache and ShutdownCRLCache should not be defined in the public header cert.h

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Wan-Teh Chang]

The internal functions InitCRLCache and ShutdownCRLCache
should not be defined in the public header file cert.h.

Comment 1

[Julien Pierre]

I think the reason why it was done that was is because those internal functions
are called accross units.
If I declare them in certdb/certi.h, how should I include it from lib/nss ?
#include "../certdb/certi.h" ?

There doesn't seem to be anything doing that currently.

Comment 2

[Wan-Teh Chang]

1. Add certi.h to the PRIVATE_EXPORTS list in
lib/certdb/manifest.mn.

2. Say #include "certi.h" from lib/nss or any
other directory.

Mac does not allow a pathname in #include
directives, so #include "../certdb/certi.h"
will break Mac builds.  See
http://bugzilla.mozilla.org/show_bug.cgi?id=166933#c3.

Comment 3

[Julien Pierre]

Attachment: patch to move InitCRLCache and ShutdownCRLCache to private header certi.h

Comment 4

[Julien Pierre]

Checking in certdb/cert.h;
/cvsroot/mozilla/security/nss/lib/certdb/cert.h,v  <--  cert.h
new revision: 1.25; previous revision: 1.24
done
Checking in certdb/certi.h;
/cvsroot/mozilla/security/nss/lib/certdb/certi.h,v  <--  certi.h
new revision: 1.7; previous revision: 1.6
done
Checking in certdb/manifest.mn;
/cvsroot/mozilla/security/nss/lib/certdb/manifest.mn,v  <--  manifest.mn
new revision: 1.10; previous revision: 1.9
done
Checking in nss/nssinit.c;
/cvsroot/mozilla/security/nss/lib/nss/nssinit.c,v  <--  nssinit.c
new revision: 1.57; previous revision: 1.56
done

Comment 5

[Wan-Teh Chang]

Comment on attachment 101791 [details] [diff] [review]
patch to move InitCRLCache and ShutdownCRLCache to private header certi.h

r=wtc.