1726809 - Remove the void QuotaManager::GetOrCreate variant

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task)

Description

[Jens Stutte [:jstutte]]

The void QuotaManager::GetOrCreate(nsIRunnable* aCallback) variant hides eventual errors (like NS_ERROR_ILLEGAL_DURING_SHUTDOWN) that might happen here from the caller. It seems cleaner, to use the variant with error return.

Comment 1

[Haiyang Xu]

Attachment: Bug 1726809 - Remove the void QuotaManager::GetOrCreate variant; r=#dom-storage-reviewers

Comment 2

[Haiyang Xu]

Attachment: Bug 1726809 - Handle the return value of QuotaManager::GetOrCreate; r=#dom-storage-reviewers

Depends on D126185

Comment 3

[Haiyang Xu]

Attachment: Bug 1726809 - Remove unnecessary callback pointer passed into QuotaManager::GetOrCreate; r=#dom-storage-reviewers

Depends on D126499

Comment 4

[Haiyang Xu]

Attachment: Bug 1726809 - Simplify QuotaManager::GetOrCreate and intermediate state of opening QuotaManager; r=#dom-storage-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4b0ae95055b
Simplify QuotaManager::GetOrCreate and intermediate state of opening QuotaManager; r=dom-storage-reviewers,janv

Comment 6

[Atila Butkovits]

Backed out for causing build bustages at ActorsParent.cpp.

Backout link: https://hg.mozilla.org/integration/autoland/rev/89abe8c922bdcd4a199d8bff4d973889bf852163

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=b4b0ae95055b2e9e2c699ea2778c13505f8c4748&selectedTaskRun=Y7ITCIWfR6SuFe-XmvJYBA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=359337069&repo=autoland&lineNumber=39743

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d3ee7e66237
Simplify QuotaManager::GetOrCreate and intermediate state of opening QuotaManager; r=dom-storage-reviewers,janv

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5d3ee7e66237

Comment 9

[Haiyang Xu]

Build error fixed.