1726914 - Bookmark folder preference "value isn't any of these" makes Ctrl+D stop working

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Jonathan]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

91.0.1 (64-bit), Mozilla Firefox for Ubuntu, canonical - 1.0
Ubuntu 21.04

• New profile
• about:config
• Search bookmark
• Change browser.bookmarks.defaultLocation from toolbar to NowUseOtherBookmarks
• New tab
• wikipedia.org
• Ctrl+D

Actual results:

Nothing

Expected results:

Bookmark-popup

As per https://searchfox.org/comm-central/source/mozilla/browser/app/profile/firefox.js#688

"If we use the pref but the value isn't any of these, we'll fall back to the bookmarks toolbar as a default"

(browser.toolbars.bookmarks.2h2020 was set to true, as is the default. When set to false, Ctrl+D works without refreshing the page)

Related enough to mention: https://bugzilla.mozilla.org/show_bug.cgi?id=1672486

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Pablo]

I was able to replicate this on windows10 64bit, Mac0S 10.15 and Ubuntu 20 64bit using firefox release 91.0.1 , beta 92.0b7 and nightly 93.0a1

Comment 3

[Marco Bonardo [:mak]]

This is strange because the code at https://searchfox.org/mozilla-central/rev/50c3cf7a3c931409b54efa009795b69c19383541/browser/components/places/PlacesUIUtils.jsm#1697-1714 seems to fallback properly, it should be investigated, I'm happy to help with that.

Comment 4

[Jane Kotovich (:janey)]

Would love to work on that!

Comment 5

[Jane Kotovich (:janey)]

Attachment: Bug 1726914. Bookmark folder preference - value isnt any of these - makes ctr+d stop working. r=mak

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ef75f9a8806
Bookmark folder preference  - value isnt any of these - makes ctr+d stop working. r=mak

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/6ef75f9a8806

Comment 8

[Virgil Sangerean]

Verified on 96.0 build 2 Firefox on Windows 10X64 and Ubuntu 20.