1727144 - CKR_ARGUMENTS_BAD Crash in [@ osclientcerts_static::C_FindObjectsInit]

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Chris Peterson [:cpeterson]]

The first crash report is from Beta 89.0b5. Historically, there was only 1–3 reports per release cycle, but we had 18 reports from (one install of) Beta 92.0b2.

I only see reports from macOS and Windows. Most of the crash URLs are about: pages like about:blank, about:newtab, or about:sessionrestore.

Crash report: https://crash-stats.mozilla.org/report/index/d4689623-92b0-4847-95b3-47fdb0210822

Reason: EXC_SOFTWARE / SIGABRT

Top 10 frames of crashing thread:

0 libsystem_kernel.dylib __pthread_kill 
1 libsystem_c.dylib abort 
2 libosclientcerts.dylib panic_abort::__rust_start_panic::abort library/panic_abort/src/lib.rs:43
3 libosclientcerts.dylib __rust_start_panic library/panic_abort/src/lib.rs:38
4 libosclientcerts.dylib rust_panic library/std/src/panicking.rs:670
5 libosclientcerts.dylib std::panicking::rust_panic_with_hook library/std/src/panicking.rs:640
6 libosclientcerts.dylib std::panicking::begin_panic_handler::{{closure}} library/std/src/panicking.rs:519
7 libosclientcerts.dylib std::sys_common::backtrace::__rust_end_short_backtrace library/std/src/sys_common/backtrace.rs:141
8 libosclientcerts.dylib rust_begin_unwind library/std/src/panicking.rs:515
9 libosclientcerts.dylib std::panicking::begin_panic_fmt library/std/src/panicking.rs:457

This code appears to intend to log an error message and return, but is instead panicking inside log_with_thread_id:

    match manager.start_search(hSession, attrs) {
        Ok(()) => {}
        Err(e) => {
            log_with_thread_id!(error, "C_FindObjectsInit: CKR_ARGUMENTS_BAD: {}", e);
            return CKR_ARGUMENTS_BAD;

https://hg.mozilla.org/mozilla-central/file/2374a282fbbb201d2bc1fd39c7dcbf0dab568bb5/security/manager/ssl/osclientcerts/src/lib.rs#l614

Comment 1

[Allison Naaktgeboren :ally]

I encountered this crash this morning. Notably, the OS dialog about "this is a unix application from the internet, are you sure you want to open it" appeared, as though I had recently installed it (though I did not) and was starting it for the first time.

It crashed both instances of Nightly & my beta. Then it put me in a repeating crash state until I killed all the processes associated with both firefoxen. Upon restart, beta appears fine, but Nightly dropped a few tabs.

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: Bug 1727144 - osclientcerts: "item not found" is not an error r?jschanck

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe4a37d10dbd
osclientcerts: "item not found" is not an error r=jschanck

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/fe4a37d10dbd