Closed Bug 172716 Opened 22 years ago Closed 22 years ago

Browse button launches blank page

Categories

(SeaMonkey :: Composer, defect)

defect
Not set
critical

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: bugzilla, Assigned: jag+mozilla)

References

Details

(Keywords: regression, smoketest, Whiteboard: [adt3])

Attachments

(1 file, 1 obsolete file)

found using 2002.10.04 commercial trunk builds on linux rh7.2 and mac 10.2.1.

1. open a file in composer.
2. click the Browse button in the toolbar.

results: the resulting browser window is blank.

no js console output, unfortunately.
Keywords: nsbeta1, regression
kathy, pls do reassign as needed. thanks!
whups, forgot to turn on the js/chrome debug pref for the profile i was using.
after that, i did get the following js console output after clicking the Browse
button:

Error: window.arguments[0].split is not a function
Source File: chrome://navigator/content/navigator.js
Line: 500

relevant or not?
The Browse button works fine for me in Win98-SE, Mozilla 1.2alpha.
Whiteboard: EDITORBASE
This is a regression caused by jag's checkin for bug 118835 (or so it would appear).
I have a patch, let me attach it here.

Fix is simple, composer was depending on navigator stringifying the object that
was passed in.
*** Bug 173183 has been marked as a duplicate of this bug. ***
Actually, Composer generally uses "GetDocumentUrl()" (which gets the url string 
from the document) instead of "window.location" or "window.location.href" This 
command seems to be the only user of the "window.location..." pattern. Sorry!
Please test using "GetDocumentUrl()" instead. It seems to work for me.
Hmmm. But now I see that we are comparing to "browser._content.location.href"
when trying to find an existing browser window with the url we are previewing.
I wonder if it's safer to use "window.location.href" in these circumstances?
Comment on attachment 102092 [details] [diff] [review]
Fix composer to give browser a string object, make browser stringify incoming objects just in case

r=brade
I think it's fine to use window._content.location.href for this place; plus it
will be more consistent if this needs to land on the 1.0 branch
Attachment #102092 - Flags: review+
Comment on attachment 102186 [details] [diff] [review]
Use GetDocumentUrl and getBrowser().currentURI.spec instead

r=cmanske
Attachment #102186 - Flags: review+
Keywords: smoketest
Comment on attachment 102186 [details] [diff] [review]
Use GetDocumentUrl and getBrowser().currentURI.spec instead

>+      var uriArray = ("" + window.arguments[0]).split('\n'); // stringify and split

window.arguments[0].toString().split() would have looked prettier, but I'm fine
with this.

sr=dveditz
Attachment #102186 - Flags: superreview+
-->jag since this is his patch

Jag--did this fix also land on the 1.0x branch to fix the problem there?
Assignee: brade → jaggernaut
Nav triage team: nsbeta1+/adt3
Keywords: nsbeta1nsbeta1+
Whiteboard: EDITORBASE → [adt3] EDITORBASE
Doh, yes, this made it onto the branch. It must've slipped my mind for the
trunk, I thought I had checked it in but bonsai says otherwise.

I'll try and get it in.
Attachment #102186 - Flags: approval+
Comment on attachment 102186 [details] [diff] [review]
Use GetDocumentUrl and getBrowser().currentURI.spec instead

a=asa for checkin to 1.2 (on behalf of drivers).
This is fixed on win XP branch build 2002102209, linux branch build 2002102207
and Mac OS X branch build 2002102105, adding verified1.0.2 keyword
Keywords: verified1.0.2
*** Bug 175519 has been marked as a duplicate of this bug. ***
Removing EDITORBASE, does not match the criteria for editorbase.
Whiteboard: [adt3] EDITORBASE → [adt3]
looks like this has already been checked in on the trunk (at least with a 10/29
build). marking resolved --but do reopen if there are other things remaining to
be done here!
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
been fixed on trunk for a while. :)
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: