devtools.netmonitor.saveRequestAndResponseBodies=false preference doesn't work
Categories
(DevTools :: Console, defect, P3)
Tracking
(firefox93 fixed)
| Tracking | Status | |
|---|---|---|
| firefox93 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
With the new fission codepath, listening to network events via the ResourceCommand API, this preference isn't applied because this is only set via the legacy codepath involving the console actor:
https://searchfox.org/mozilla-central/rev/4cca5d2f257c6f1bcef50a0debcbd66524add703/devtools/client/webconsole/webconsole-connection-proxy.js#57-62
Also, we do emit one setSaveRequestAndResponseBodies for each target, whereas we only need one such request with the new codepath.
Doing many leads to intermittent failure with pending request in bug 1724002.
|
Assignee | |
Comment 1•3 years ago
|
||
We weren't applying the preference to the parent process NetworkEventWatcher
because we were only trying to update this via the WebConsole actor.
In addition, this was introducing intermittent failures in browser_toolbox_frames_list.js
because of the pending request made to the console actor.
Doing only one unique request to NetworkEventParent helps reducing the number of requests and intermittents.
|
||
Updated•3 years ago
|
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/142afd303479 [devtools] Fix devtools.netmonitor.saveRequestAndResponseBodies preference with new fission codepath. r=bomsy,devtools-backward-compat-reviewers
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Description
•