1727180 - MOZ_CRASH(Failed to get app path) at ipc/glue/GeckoChildProcessHost.cpp:1709

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Kershaw Chang [:kershaw]]

When running xpcshell tests with socket process enabled on my macbook locally, I hit this crash.

Hit MOZ_CRASH(Failed to get app path) at /Users/changkershaw/work/gecko/ipc/glue/GeckoChildProcessHost.cpp:1709
#01: mozilla::ipc::GeckoChildProcessHost::FillMacSandboxInfo(_MacSandboxInfo&)[/Users/changkershaw/work/gecko/objdir/toolkit/library/build/XUL +0x9ab8dc]
#02: mozilla::net::SocketProcessHost::FillMacSandboxInfo(_MacSandboxInfo&)[/Users/changkershaw/work/gecko/objdir/toolkit/library/build/XUL +0x8cd59e]
#03: mozilla::ipc::GeckoChildProcessHost::AppendMacSandboxParams(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::all[/Users/changkershaw/work/gecko/objdir/toolkit/library/build/XUL +0x9ab78f]
#04: mozilla::ipc::GeckoChildProcessHost::AsyncLaunch(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char[/Users/changkershaw/work/gecko/objdir/toolkit/library/build/XUL +0x9a7543]
#05: mozilla::ipc::GeckoChildProcessHost::LaunchAndWaitForProcessHandle(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::_[/Users/changkershaw/work/gecko/objdir/toolkit/library/build/XUL +0x9a8566]
#06: mozilla::net::SocketProcessHost::Launch()[/Users/changkershaw/work/gecko/objdir/toolkit/library/build/XUL +0x8cc74e]
#07: mozilla::net::nsIOService::LaunchSocketProcess()[/Users/changkershaw/work/gecko/objdir/toolkit/library/build/XUL +0x335444]

Comment 1

[Kershaw Chang [:kershaw]]

It seems that the reason is that CommandLine is not initialized when running xpcshell.
Adding XRE_InitCommandLine in XRE_XPCShellMain seems to be able to fixes this problem.

Comment 2

[Andrew McCreight [:mccr8]]

Sorry, I missed that this was with XPCShell.

Comment 3

[Kershaw Chang [:kershaw]]

More details:
nsMacUtilsImpl::GetAppPath failed because appBinaryPath here is an uninitialized value.

Comment 4

[Chris Peterson [:cpeterson]]

Since this is an XPCShell bug, I'm moving it to the XPCOM component.

Comment 5

[Kershaw Chang [:kershaw]]

Attachment: Bug 1727180 - Call XRE_InitCommandLine for xpcshell, r=#xpcom-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/442a7912f2cf
Call XRE_InitCommandLine for xpcshell, r=glandium

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/442a7912f2cf