Closed Bug 1727289 Opened 2 months ago Closed 2 months ago

[win] Print preview scroll bar is wider

Categories

(Core :: Print Preview, defect)

Desktop
Windows
defect

Tracking

()

VERIFIED FIXED
93 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- verified
firefox91 --- wontfix
firefox92 --- wontfix
firefox93 --- verified

People

(Reporter: atrif, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image print_preview

Affected versions

  • 91.0.2 (20210823123856)
  • 92.0b7 (20210822190301)
  • 93.0a1 (20210824094724)

Affected platforms

  • Windows 10x64

Steps to reproduce

  1. Open Firefox and go to a website that has many pages.
  2. Enter the Print preview and observe the scroll bar.

Expected result

  • Scrollbar has the same dimensions as the one from the browser.

Actual result

  • Scroll bar is wider.

Regression range

Notes

  • Attached a screenshot.
  • The issue is reproducible on Windows only.
Has Regression Range: --- → yes
Has STR: --- → yes
Flags: needinfo?(emilio)
Flags: needinfo?(emilio)

Print preview documents might use a different DPI depending on the print
target.

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3696b26ff0a2
Prefer widget scale for scrollbar parts. r=mstange
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3766f621ddb0
null-check root pres context to avoid crashes on automation in some cases.
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch

Verified fixed with 93.0a1 (20210831031805) from comment 4 on Windows 10x64. The scroll bar inside the print preview is displayed as expected.

Status: RESOLVED → VERIFIED

Is this something we should consider taking on ESR91?

Flags: needinfo?(emilio)

It's a minor cosmetic issue, but it should be safe. Your call.

Flags: needinfo?(emilio) → needinfo?(ryanvm)

Go ahead and nominate, seems like a simple-enough patch to take this early in the lifecycle.

Flags: needinfo?(ryanvm) → needinfo?(emilio)

Comment on attachment 9238481 [details]
Bug 1727289 - Prefer widget scale for scrollbar parts. r=mstange

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: See above.
  • User impact if declined: comment 0
  • Fix Landed on Version: 93
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Pretty straight-forward fix.
  • String or UUID changes made by this patch: none
Flags: needinfo?(emilio)
Attachment #9238481 - Flags: approval-mozilla-esr91?

Comment on attachment 9238481 [details]
Bug 1727289 - Prefer widget scale for scrollbar parts. r=mstange

Approved for 91.2esr.

Attachment #9238481 - Flags: approval-mozilla-esr91? → approval-mozilla-esr91+

Verified fixed with 91.2.0esr (20210927140538) on Windows 10x64.

You need to log in before you can comment on or make changes to this bug.