1727289 - [win] Print preview scroll bar is wider

Status: VERIFIED FIXED

(Core :: Print Preview, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: print_preview

Affected versions

• 91.0.2 (20210823123856)
• 92.0b7 (20210822190301)
• 93.0a1 (20210824094724)

Affected platforms

• Windows 10x64

Steps to reproduce

1. Open Firefox and go to a website that has many pages.
2. Enter the Print preview and observe the scroll bar.

Expected result

• Scrollbar has the same dimensions as the one from the browser.

Actual result

• Scroll bar is wider.

Regression range

• Last good revision: 64bc9459015c77f3a032bc4dcb9465c44281b7d9
  First bad revision: e2e3769604efd9724670ca1474377789e003a992
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=64bc9459015c77f3a032bc4dcb9465c44281b7d9&tochange=e2e3769604efd9724670ca1474377789e003a992

Notes

• Attached a screenshot.
• The issue is reproducible on Windows only.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1727289 - Prefer widget scale for scrollbar parts. r=mstange

Print preview documents might use a different DPI depending on the print
target.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3696b26ff0a2
Prefer widget scale for scrollbar parts. r=mstange

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3766f621ddb0
null-check root pres context to avoid crashes on automation in some cases.

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/3696b26ff0a2
https://hg.mozilla.org/mozilla-central/rev/3766f621ddb0

Comment 5

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with 93.0a1 (20210831031805) from comment 4 on Windows 10x64. The scroll bar inside the print preview is displayed as expected.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider taking on ESR91?

Comment 7

[Emilio Cobos Álvarez (:emilio)]

It's a minor cosmetic issue, but it should be safe. Your call.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Go ahead and nominate, seems like a simple-enough patch to take this early in the lifecycle.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9238481 [details]
Bug 1727289 - Prefer widget scale for scrollbar parts. r=mstange

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: See above.
• User impact if declined: comment 0
• Fix Landed on Version: 93
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Pretty straight-forward fix.
• String or UUID changes made by this patch: none

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9238481 [details]
Bug 1727289 - Prefer widget scale for scrollbar parts. r=mstange

Approved for 91.2esr.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/9e4857713532

Comment 12

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with 91.2.0esr (20210927140538) on Windows 10x64.