1727301 - Relaxing referrer restrictions should be enabled by the shield menu toggle

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement, P2)

Description

[Johann Hofmann [:johannh]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1720294#c11, we decided that to avoid breakage we should have the ETP toggle (tracking-protection permission) allow websites to relax referrer restrictions. We would probably have to cache the preferred referrer value and restore it when the user toggles the button.

Tim, can you make sure this bug is listed in the requirements doc for disallow-relaxing-referrer in Standard mode? Thanks!

Comment 1

[Tim Huang[:timhuang]]

Attachment: Bug 1727301 - Part 1: Remeber the original referrer policy in the ReferrerInfo. r?ckerschb

The referrer policy could be overridden in two cases; one is the
referrer policy wasn't set, another is that the original policy was
ignored.

In order to recover the original policy if the ETP was off, we need to
store the original referrer policy so that we can recompute the referrer
policy based on that.

Comment 2

[Tim Huang[:timhuang]]

Attachment: Bug 1727301 - Part 2: The disallowing less restricted referrer policy can be disabled by ETP toggle. r?ckerschb!,pbz!

This patch implements that the referrer protection can be disabled by
the ETP toggle. When ETP is toggled off, it will stop the protection for
iframe and sub-resource loads. Also, it will stop the protection for a
loading to a site that has ETP disabled.

This patch also makes
CookieJarSettings::UpdateIsOnContentBlockingAllowList() be more
efficient when calling it multiple times.

Depends on D142248

Comment 3

[Tim Huang[:timhuang]]

Attachment: Bug 1727301 - Part 3: Add tests for testing ETP toggle with the disallow relaxing referrer policy. r?ckerschb

This patch add tests for testing ETP toggle with the disallow relaxing
referrer policies. In addition, it changes the test a little bit to
improve the testing performance.

Depends on D142249

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e741cf30431
Part 1: Remeber the original referrer policy in the ReferrerInfo. r=ckerschb,smaug
https://hg.mozilla.org/integration/autoland/rev/cf85158b21fd
Part 2: The disallowing less restricted referrer policy can be disabled by ETP toggle. r=ckerschb,pbz,smaug
https://hg.mozilla.org/integration/autoland/rev/454781280760
Part 3: Add tests for testing ETP toggle with the disallow relaxing referrer policy. r=ckerschb

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/2e741cf30431
https://hg.mozilla.org/mozilla-central/rev/cf85158b21fd
https://hg.mozilla.org/mozilla-central/rev/454781280760