Closed
Bug 1727342
Opened 3 years ago
Closed 3 years ago
`--requirement` flag of `find-hg-repos.py` script is broken
Categories
(Developer Services :: Mercurial: hg.mozilla.org, defect)
Developer Services
Mercurial: hg.mozilla.org
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sheehan, Assigned: sheehan)
Details
Attachments
(1 file)
The test is failing and running the command on the server does not correctly identify repositories with a given requirement.
|
Assignee | |
Comment 1•3 years ago
|
||
The value for --requirement was being passed as a str, while
the was being read and each line in the file was passed as a bytes,
leading to comparisons like "store" == b"store", which is False.
Opening the file in regular read mode makes both values str and the
comparison is correct again.
Depends on D123479
Pushed by cosheehan@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/108acc302646
hgmolib: open file in regular mode when parsing requires files r=zeid
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•