1727361 - Firefox tries to decode an Objective-C file from Searchfox as if it were FLAC audio

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

STR:

1. Go to https://searchfox.org/mozilla-central/source/gfx/layers/NativeLayerCA.mm

ER:

I should see a source code listing.

AR:

In Firefox 93, a media player appears instead. The DevTools network view thinks the document is a FLAC audio file. The console says:

Media resource https://searchfox.org/mozilla-central/source/gfx/layers/NativeLayerCA.mm could not be decoded, error: Error Code: NS_ERROR_DOM_MEDIA_DEMUXER_ERR (0x806e000c)

Response headers:

HTTP/2 200 OK
date: Tue, 24 Aug 2021 15:24:56 GMT
content-type: text/html
content-length: 68268
server: nginx/1.18.0 (Ubuntu)
last-modified: Tue, 24 Aug 2021 05:02:28 GMT
etag: "61247d64-10aac"
content-encoding: gzip
expires: Tue, 24 Aug 2021 15:26:56 GMT
cache-control: max-age=120
strict-transport-security: max-age=63072000; includeSubDomains; preload
cache-control: must-revalidate
X-Firefox-Spdy: h2

Request headers:

GET /mozilla-central/source/gfx/layers/NativeLayerCA.mm HTTP/2
Host: searchfox.org
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:93.0) Gecko/20100101 Firefox/93.0
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,*/*;q=0.8
Accept-Language: en-GB,en-US;q=0.7,en;q=0.3
Accept-Encoding: gzip, deflate, br
DNT: 1
Connection: keep-alive
Upgrade-Insecure-Requests: 1
Sec-Fetch-Dest: document
Sec-Fetch-Mode: navigate
Sec-Fetch-Site: cross-site
Pragma: no-cache
Cache-Control: no-cache

Comment 1

[Paul Adenot (:padenot)]

Probably a regression from 1704115. Very unlucky byte pattern.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1704115

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

To clarify, this no longer reproduces at the above URL, as the page was re-indexed, so the byte pattern has changed.

Comment 4

[Paul Adenot (:padenot)]

Attachment: Bug 1727361 - Don't sniff for a FLAC stream, it's not deterministic enough and no spec exist. r?bryce

Besides, live streaming in FLAC is (always?) done in OGG container.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13b01785e531
Don't sniff for a FLAC stream, it's not deterministic enough and no spec exist. r=bryce

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/13b01785e531