1727371 - Firefox uses a light background on startup with system theme and an OS dark theme

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Danny Colin [:sdk]]

Attachment: firefox-white-flash-2021-08-24_12.41.54.mkv

STR:

0. Set a dark theme for your OS (e.g Adwaita-dark)
1. Set "system theme" in Firefox
2. Close and re-open Firefox

AB:

There's a small delay before the chrome UI is completely loaded and during that time Firefox uses a light color (white) for the background instead of a dark color.

EB:

It should use a dark color.

Additional information:

According to mozregression (see link below) it has been introduced by bug 1707957. However, I only got that issue around the time where Proton was released and that some clean up have been done to remove the pre-Proton code. So the clean up may have broken the patch in the bug mentioned above.

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=365bfc91ddd5d9be1a5d5bee72377c025b099321&tochange=a57a18bd5034b718955a35fecea22727d556e35f

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Hmm, I don't see this on Fedora 34 (tried two different machines, with pretty much a stock wayland setup). Are you using x11 or wayland?

From the video I see you're using Gnome with perhaps some sort of tiling extension or something, can you elaborate on how can I get to repro this?

Comment 2

[Danny Colin [:sdk]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)

Hmm, I don't see this on Fedora 34 (tried two different machines, with pretty much a stock wayland setup). Are you using x11 or wayland?
From the video I see you're using Gnome with perhaps some sort of tiling extension or something, can you elaborate on how can I get to repro this?

OS: Fedora 34
Window Manager: bspwm
Display Server: x11

I've also attached the output of about:support. And, I do use a userChrome.css but I disabled it and was able to reproduce the issue.

Comment 3

[Danny Colin [:sdk]]

Attachment: about-support.txt

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Thanks, will try to repro with that WM.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1727371 - Use the right color scheme for default background/color lookup on chrome docs. r=mstange

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb30adfdd26d
Use the right color scheme for default background/color lookup on chrome docs. r=mstange

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/bb30adfdd26d