Closed Bug 1727400 Opened 3 months ago Closed 3 months ago

[wpt-sync] Sync PR 30159 - [WebCodecs] Implement support for converting AudioData to float32.

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox93 fixed)

RESOLVED FIXED
93 Branch
Tracking Status
firefox93 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30159 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30159
Details from upstream follow.

b'Dale Curtis <dalecurtis@chromium.org>' wrote:

[WebCodecs] Implement support for converting AudioData to float32.

This adds an optional format parameter to the AudioDataCopyToOptions
so that developers can easily interoperate with AudioBuffer. Only
f32-planar is supported at present and a NotSupportedError is thrown
for all other formats.

Conversion is done once into a temporary AudioBus that sticks around
for the lifetime of the AudioData object. We can evaluate switching
to a just-in-time conversion later, but to ensure this can make the
M94 branch, this makes the minimal number of changes required.

R=tguilbert

Bug: 1243034
Change-Id: I31f96f6bc56abe640af92788646ae75c534d6b2b

Reviewed-on: https://chromium-review.googlesource.com/3116565
WPT-Export-Revision: 9f2e4eb3cc797e28f6e218f5a53eea17ca2a5c85

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 7 subtests

Status Summary

Firefox

OK : 2
FAIL: 14

Chrome

OK : 2
PASS: 6
FAIL: 8

Safari

OK : 2
FAIL: 14

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webcodecs/audio-data.any.html
Verify AudioData constructors: FAIL (Chrome: PASS, Safari: FAIL)
Verify closing and cloning AudioData: FAIL (Chrome: PASS, Safari: FAIL)
Test we can construct AudioData with a negative timestamp.: FAIL (Chrome: PASS, Safari: FAIL)
Test conversion of uint8 data to float32: FAIL (Chrome: FAIL, Safari: FAIL)
Test conversion of int16 data to float32: FAIL (Chrome: FAIL, Safari: FAIL)
Test conversion of int32 data to float32: FAIL (Chrome: FAIL, Safari: FAIL)
Test conversion of float32 data to float32: FAIL (Chrome: FAIL, Safari: FAIL)
/webcodecs/audio-data.any.worker.html
Verify AudioData constructors: FAIL (Chrome: PASS, Safari: FAIL)
Verify closing and cloning AudioData: FAIL (Chrome: PASS, Safari: FAIL)
Test we can construct AudioData with a negative timestamp.: FAIL (Chrome: PASS, Safari: FAIL)
Test conversion of uint8 data to float32: FAIL (Chrome: FAIL, Safari: FAIL)
Test conversion of int16 data to float32: FAIL (Chrome: FAIL, Safari: FAIL)
Test conversion of int32 data to float32: FAIL (Chrome: FAIL, Safari: FAIL)
Test conversion of float32 data to float32: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/53e87b112d43
[wpt PR 30159] - [WebCodecs] Implement support for converting AudioData to float32., a=testonly
https://hg.mozilla.org/integration/autoland/rev/cbe2d30052fd
[wpt PR 30159] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.