Define Glean capability for GeckoView
Categories
(GeckoView :: General, task, P1)
Tracking
(firefox93 fixed)
| Tracking | Status | |
|---|---|---|
| firefox93 | --- | fixed |
People
(Reporter: agi, Assigned: agi)
References
Details
Attachments
(5 files)
We noticed that depending on Glean doesn't really work as it creates a circular dependency:
geckoview -> glean -> glean-native (substituted as geckoview)
Since Gradle 6, capabilities can be consumed from libraries using the Gradle Metadata, so we can update to Gradle 6 and offer Glean as a capability in GeckoView directly, fixing the circular dependency.
|
Assignee | |
Comment 1•3 years ago
|
||
This is the last version that doesn't require Java 11, we will upgrade to
Gradle 7 once all components are ready (namely, apilint).
Co-authored-by: Jan-Erik Rediger <janerik@fnordig.de>
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 2•3 years ago
|
||
Co-authored-by: Jan-Erik Rediger <janerik@fnordig.de>
|
|
Assignee | |
Comment 3•3 years ago
|
||
There's a lot of code that we don't need anymore in our publication path (I'm
assuming it was needed when it was written but then gradle/the android plugin
caught up).
This has the nice side effect of producing better metadata (e.g. our
implementation dependencies end up in the |runtime| dependency group instead of
the default one where they were before, which means the app doesn't inherit our
private dependencies).
Co-authored-by: Jan-Erik Rediger <janerik@fnordig.de>
|
|
Assignee | |
Comment 4•3 years ago
|
||
Depending on glean creates a circular dependency as glean depends on
glean-native which is substituted with GeckoView in omni builds.
Since Gradle 6 capabilities are passed on to consumers using the Gradle Module
Metadata, so now we can just define a glean capability in GeckoView and Fenix
will consume glean-native from GeckoView instead of adding a duplicated
libglean blob (there is code in the glean plugin to make sure this happens).
See also: https://docs.gradle.org/current/userguide/component_capabilities.html
Co-authored-by: Jan-Erik Rediger <janerik@fnordig.de>
Pushed by asferro@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/efda82445d85 Upgrade to Gradle 6.9.1. r=nalexander https://hg.mozilla.org/integration/autoland/rev/00d32a3af979 Upgrade kotlin to 1.5.20. r=nalexander https://hg.mozilla.org/integration/autoland/rev/8cba5f574196 Import publishing metadata from variant. r=nalexander https://hg.mozilla.org/integration/autoland/rev/59d1a463178b Define glean as a capability instead of depending on it. r=nalexander
|
||
Comment 6•3 years ago
|
||
Backed out for causing Android bustage.
Backout link: https://hg.mozilla.org/integration/autoland/rev/73f619a0122ac3e9c993e297c3cb41cf03cc9db2
Failure log: https://treeherder.mozilla.org/logviewer?job_id=349593987&repo=autoland&lineNumber=49314
|
|
||
Comment 7•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/efda82445d85
https://hg.mozilla.org/mozilla-central/rev/00d32a3af979
https://hg.mozilla.org/mozilla-central/rev/8cba5f574196
https://hg.mozilla.org/mozilla-central/rev/59d1a463178b
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 8•3 years ago
|
||
Looks like AC is not ready for runtime dependencies: https://github.com/mozilla-mobile/android-components/issues/10885
|
|
Assignee | |
Comment 9•3 years ago
|
||
Looks like 6G is not enough for an ASAN build when updating the gradle version.
I tried 8G on try but that's not enough either.
|
||
Comment 10•3 years ago
|
||
Pushed by asferro@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8d03d49fe3a3 Increase java max heap to 16G. r=nalexander https://hg.mozilla.org/integration/autoland/rev/ebb080f68880 Upgrade to Gradle 6.9.1. r=nalexander,owlish https://hg.mozilla.org/integration/autoland/rev/97a06ad4cbcc Upgrade kotlin to 1.5.20. r=nalexander,owlish https://hg.mozilla.org/integration/autoland/rev/e015a4e8b62e Import publishing metadata from variant. r=nalexander,owlish https://hg.mozilla.org/integration/autoland/rev/66bad7f53820 Define glean as a capability instead of depending on it. r=nalexander,owlish
|
||
Comment 11•3 years ago
|
||
Backed out for causing android build bustages.
Failure log: https://treeherder.mozilla.org/logviewer?job_id=349984409&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/a354cf5ff637484c7f568498f29f8e2454d2ad11
|
|
||
Updated•3 years ago
|
|
|
||
Comment 12•3 years ago
|
||
Pushed by asferro@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/839ea7d1556b Increase java max heap to 32G. r=nalexander,owlish https://hg.mozilla.org/integration/autoland/rev/eb725677507a Upgrade to Gradle 6.9.1. r=nalexander,owlish https://hg.mozilla.org/integration/autoland/rev/559e33eeafa8 Upgrade kotlin to 1.5.20. r=nalexander,owlish https://hg.mozilla.org/integration/autoland/rev/4db29982dbe2 Import publishing metadata from variant. r=nalexander,owlish https://hg.mozilla.org/integration/autoland/rev/2c6e3c15b81a Define glean as a capability instead of depending on it. r=nalexander,owlish
|
||
Comment 14•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/839ea7d1556b
https://hg.mozilla.org/mozilla-central/rev/eb725677507a
https://hg.mozilla.org/mozilla-central/rev/559e33eeafa8
https://hg.mozilla.org/mozilla-central/rev/4db29982dbe2
https://hg.mozilla.org/mozilla-central/rev/2c6e3c15b81a
Description
•