1727459 - Add more logs around WebRenderLayerManager::Initialize()

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task)

Description

[Sotaro Ikeda [:sotaro]]

Crash of Bug 1707475 seems to happen by widget size in WebRenderLayerManager::Initialize(). Then it seems helpful to add logs around the widget size for estimating the cause of the crash.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1727459 - Add more logs around widget size in WebRenderLayerManager::Initialize()

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b41457a3dc25
Add more logs around widget size in WebRenderLayerManager::Initialize() r=gfx-reviewers,jrmuizel

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/b41457a3dc25

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Did you want to nominate this for release approval so it can ride along with an RC respin?

Comment 5

[Sotaro Ikeda [:sotaro]]

Comment on attachment 9237895 [details]
Bug 1727459 - Add more logs around widget size in WebRenderLayerManager::Initialize()

Beta/Release Uplift Approval Request

• User impact if declined: Start up crash of Bug 1707475 could happen. Crash report says that the crash was addressed with the fix, though I could not reproduce the crash locally.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch added just a simple error handling and logs.
• String changes made/needed:

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9237895 [details]
Bug 1727459 - Add more logs around widget size in WebRenderLayerManager::Initialize()

Approved for 92.0rc2.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/280aaaa2dc42