Closed Bug 1727465 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30166 - Add visibleRect and displayWidth|Height to VideoFrameInit

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox93 fixed)

RESOLVED FIXED
93 Branch
Tracking Status
firefox93 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30166 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30166
Details from upstream follow.

b'Chris Cunningham <chcunningham@chromium.org>' wrote:

Add visibleRect and displayWidth|Height to VideoFrameInit

Allows metadata override for efficient crop/resize.
Per https://github.com/w3c/webcodecs/pull/347

Bug: 1243162
Test: New wpts.
Change-Id: I78cda24869e0e1ab5f620df53dc68298e3bfc361
Reviewed-on: https://chromium-review.googlesource.com/3117007
WPT-Export-Revision: 07f70c2b1804b60f3f8450207f318b347c45ab39

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 26 subtests

Status Summary

Firefox

OK : 2
PASS: 1
FAIL: 51

Chrome

OK : 2
PASS: 38
FAIL: 14

Safari

OK : 2
PASS: 1
FAIL: 51

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webcodecs/videoFrame-construction.any.worker.html
Test we can construct a VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
Test closed VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
Test we can construct a VideoFrame with a negative timestamp.: FAIL (Chrome: PASS, Safari: FAIL)
Test we can construct an odd-sized VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
Test constructing w/ unusable image argument throws: emtpy Canvas.: FAIL (Chrome: PASS, Safari: FAIL)
Test constructing w/ unusable image argument throws: closed ImageBitmap.: FAIL (Chrome: PASS, Safari: FAIL)
Test constructing w/ unusable image argument throws: closed VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
Test invalid CanvasImageSource constructed VideoFrames: FAIL (Chrome: FAIL, Safari: FAIL)
Test visibleRect metadata override where source display size = visible size: FAIL (Chrome: FAIL, Safari: FAIL)
Test visibleRect metadata override where source display width = 2 * visible width (anamorphic): FAIL (Chrome: FAIL, Safari: FAIL)
Test visibleRect metadata override where source display size = 2 * visible size for both width and height: FAIL (Chrome: FAIL, Safari: FAIL)
Test visibleRect + display size metadata override: FAIL (Chrome: FAIL, Safari: FAIL)
Test display size metadata override: FAIL (Chrome: FAIL, Safari: FAIL)
Test invalid buffer constructed VideoFrames: FAIL (Chrome: PASS, Safari: FAIL)
Test Uint8Array(ArrayBuffer) constructed I420 VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Test ArrayBuffer constructed I420 VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Test planar constructed I420 VideoFrame with colorSpace: FAIL (Chrome: PASS, Safari: FAIL)
Test buffer constructed I420+Alpha VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Test buffer constructed NV12 VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Test buffer constructed RGB VideoFrames: FAIL (Chrome: PASS, Safari: FAIL)
Test VideoFrame constructed VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Test we can construct a VideoFrame from an offscreen canvas.: FAIL (Chrome: PASS, Safari: FAIL)
Test I420A VideoFrame and alpha={keep,discard}: FAIL (Chrome: PASS, Safari: FAIL)
Test RGBA, BGRA VideoFrames with alpha={keep,discard}: FAIL (Chrome: PASS, Safari: FAIL)
Test a VideoFrame constructed from canvas can drop the alpha channel.: FAIL (Chrome: FAIL, Safari: FAIL)
/webcodecs/videoFrame-construction.any.html
Test we can construct a VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
Test closed VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
Test we can construct a VideoFrame with a negative timestamp.: FAIL (Chrome: PASS, Safari: FAIL)
Test we can construct an odd-sized VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
Test constructing w/ unusable image argument throws: HAVE_NOTHING <video>.: FAIL (Chrome: PASS, Safari: FAIL)
Test constructing w/ unusable image argument throws: emtpy Canvas.: FAIL (Chrome: PASS, Safari: FAIL)
Test constructing w/ unusable image argument throws: closed ImageBitmap.: FAIL (Chrome: PASS, Safari: FAIL)
Test constructing w/ unusable image argument throws: closed VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
Test invalid CanvasImageSource constructed VideoFrames: FAIL (Chrome: FAIL, Safari: FAIL)
Test visibleRect metadata override where source display size = visible size: FAIL (Chrome: FAIL, Safari: FAIL)
Test visibleRect metadata override where source display width = 2 * visible width (anamorphic): FAIL (Chrome: FAIL, Safari: FAIL)
Test visibleRect metadata override where source display size = 2 * visible size for both width and height: FAIL (Chrome: FAIL, Safari: FAIL)
Test visibleRect + display size metadata override: FAIL (Chrome: FAIL, Safari: FAIL)
Test display size metadata override: FAIL (Chrome: FAIL, Safari: FAIL)
Test invalid buffer constructed VideoFrames: FAIL (Chrome: PASS, Safari: FAIL)
Test Uint8Array(ArrayBuffer) constructed I420 VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Test ArrayBuffer constructed I420 VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Test planar constructed I420 VideoFrame with colorSpace: FAIL (Chrome: PASS, Safari: FAIL)
Test buffer constructed I420+Alpha VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Test buffer constructed NV12 VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Test buffer constructed RGB VideoFrames: FAIL (Chrome: PASS, Safari: FAIL)
Test VideoFrame constructed VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Test we can construct a VideoFrame from an offscreen canvas.: FAIL (Chrome: PASS, Safari: FAIL)
Test I420A VideoFrame and alpha={keep,discard}: FAIL (Chrome: PASS, Safari: FAIL)
Test RGBA, BGRA VideoFrames with alpha={keep,discard}: FAIL (Chrome: PASS, Safari: FAIL)
Test a VideoFrame constructed from canvas can drop the alpha channel.: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7ba7d03ec6fc
[wpt PR 30166] - Add visibleRect and displayWidth|Height to VideoFrameInit, a=testonly
https://hg.mozilla.org/integration/autoland/rev/c4d806600ee4
[wpt PR 30166] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.