1727467 - Replace some char* allocs with nsCString in nsImapBodyShell

Status: NEW

(MailNews Core :: General, task)

Description

[Ben Campbell]

There's a bit of char* usage in nsImapBodyShell that'd benefit from using ns[A]CString instead.

Comment 1

[Ben Campbell]

Attachment: Bug 1727467 - Use nsCString to store nsImapBodyShell folder name instead of allocating char buffer. r=mkmelin

Depends on D123580

Comment 2

[Ben Campbell]

Setting leave-open. It looks like the char* replacement could continue upward a layer or two up the callstack, so there'll probably be another patch or two to come.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bb0d25b8f6d7
Use nsCString to store nsImapBodyShell folder name instead of allocating char buffer. r=mkmelin

Comment 4

[José M. Muñoz]

https://hg.mozilla.org/comm-central/rev/bb0d25b8f6d7979fff31adea983b6b75a7091be8#l3.14
Why not use nsDependentCString()?

Comment 5

[Ben Campbell]

(In reply to José M. Muñoz from comment #4)

Why not use nsDependentCString()?

Good point - thanks! Patch incoming.

Comment 6

[Ben Campbell]

Attachment: Bug 1727467 - Some minor nsDependentCString fixups in nsImapHostSessionList. r=mkmelin

Comment 7

[José M. Muñoz]

That still doesn't follow the usual path that is taken when converting raw string to smart string, example here:
https://hg.mozilla.org/comm-central/rev/88afdfc38ae6#l2.49
You don't need the variables.

Comment 8

[Ben Campbell]

(In reply to José M. Muñoz from comment #7)

You don't need the variables.

Patch revised (Small enough change that I kept the existing r+) - thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/312205101b78
Some minor nsDependentCString fixups in nsImapHostSessionList. r=mkmelin

Comment 10

[Ben Campbell]

The partNum handling is a bit infuriating - it takes a little unpicking to figure out the ownership of the raw char*. So the next step here would be to use string objects instead. Changes would spread across nsImapBodyShell and nsImapUrl.