1727562 - layout/base/nsFrameTraversal.cpp: do not use 'else' after 'break'

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[jaygala260]

+++ This bug was initially created as a clone of Bug #1713521 +++

do not use 'else' after 'break':
https://searchfox.org/mozilla-central/source/layout/base/nsFrameTraversal.cpp#257-261

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Why the needinfo?

Comment 2

[jaygala260]

Attachment: Bug 1727562 - removed 'else' after 'break' at lines 257-261. r?emilio

Comment 3

[Phabricator Automation]

Comment on attachment 9237977 [details]
Bug 1727562 - removed 'else' after 'break' at lines 257-261. r?emilio

Revision D123590 was moved to bug 1713521. Setting attachment 9237977 [details] to obsolete.

Comment 4

[jaygala260]

Attachment: WIP: Bug 1727562 - Removed 'else' after 'break', improved indentation

Depends on D123590

Comment 5

[jaygala260]

Attachment: Bug 1727562 - Removed 'else' after 'break', improved indentation. r?emilio

Depends on D123647

Comment 6

[Phabricator Automation]

Comment on attachment 9237987 [details]
Bug 1727562 - Removed 'else' after 'break', improved indentation. r?emilio

Revision D123648 was moved to bug 1713521. Setting attachment 9237987 [details] to obsolete.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:dholbert, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 8

[Daniel Holbert [:dholbert]]

Looks like the patch had a bunch of unrelated whitespace fixes, which is why it never landed.

The issue still remains (we still have else-after-break in the referenced code), so the bug is still valid.

Comment 9

[Daniel Holbert [:dholbert]]

Attachment: Bug 1727562: Avoid else-after-break in nsFrameTraversal.cpp, and add braces to one-liner if-statements. r?#layout-reviewers

This patch doesn't change behavior; it just makes this code more consistent
with our coding style.

Comment 10

[Daniel Holbert [:dholbert]]

It's a trivial change, so let's just fix it rather than leaving this open indefinitely.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fdc054e07f02
Avoid else-after-break in nsFrameTraversal.cpp, and add braces to one-liner if-statements. r=emilio

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/fdc054e07f02