layout/base/nsFrameTraversal.cpp: do not use 'else' after 'break'
Categories
(Core :: Layout, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox101 | --- | fixed |
People
(Reporter: jaygala260, Assigned: dholbert, Mentored)
Details
Attachments
(1 file, 3 obsolete files)
+++ This bug was initially created as a clone of Bug #1713521 +++
do not use 'else' after 'break':
https://searchfox.org/mozilla-central/source/layout/base/nsFrameTraversal.cpp#257-261
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
|
||
Comment 1•3 years ago
|
||
Why the needinfo?
|
Reporter | |
Comment 2•3 years ago
|
||
|
||
Updated•3 years ago
|
|
|
||
Comment 3•3 years ago
|
||
Comment on attachment 9237977 [details]
Bug 1727562 - removed 'else' after 'break' at lines 257-261. r?emilio
Revision D123590 was moved to bug 1713521. Setting attachment 9237977 [details] to obsolete.
|
|
Reporter | |
Comment 4•3 years ago
|
||
Depends on D123590
|
|
Reporter | |
Comment 5•3 years ago
|
||
Depends on D123647
|
|
||
Updated•3 years ago
|
|
|
||
Comment 6•3 years ago
|
||
Comment on attachment 9237987 [details]
Bug 1727562 - Removed 'else' after 'break', improved indentation. r?emilio
Revision D123648 was moved to bug 1713521. Setting attachment 9237987 [details] to obsolete.
|
|
Reporter | |
Updated•3 years ago
|
|
||
Comment 7•2 years ago
|
||
The bug assignee didn't login in Bugzilla in the last 7 months.
:dholbert, could you have a look please?
For more information, please visit auto_nag documentation.
|
Assignee | |
Comment 8•2 years ago
|
||
Looks like the patch had a bunch of unrelated whitespace fixes, which is why it never landed.
The issue still remains (we still have else-after-break in the referenced code), so the bug is still valid.
|
|
Assignee | |
Comment 9•2 years ago
|
||
This patch doesn't change behavior; it just makes this code more consistent
with our coding style.
|
|
||
Updated•2 years ago
|
|
|
Assignee | |
Comment 10•2 years ago
|
||
It's a trivial change, so let's just fix it rather than leaving this open indefinitely.
|
|
Assignee | |
Updated•2 years ago
|
|
||
Comment 11•2 years ago
|
||
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fdc054e07f02 Avoid else-after-break in nsFrameTraversal.cpp, and add braces to one-liner if-statements. r=emilio
|
||
Comment 12•2 years ago
|
||
| bugherder | ||
Description
•