Closed Bug 1727628 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30183 - Reject AudioData invalid indexes

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox93 fixed)

Status:
RESOLVED FIXED
Milestone:
93 Branch
Tracking Flags:
Tracking Status
firefox93 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30183 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30183
Details from upstream follow.

b'Thomas Guilbert <tguilbert@chromium.org>' wrote:

Reject AudioData invalid indexes

This CL fixes an issue, where AudioData with interleaved formats do not
reject operations with AudioDataCopyToOptions.planeIndex > 0.

Interleaved formats can only every have one plane, regardless of the
number or channels.

Bug: 1243210
Change-Id: Idae0891f01c3928f89ca57a60763cb57368d58ed
Reviewed-on: https://chromium-review.googlesource.com/3119810
WPT-Export-Revision: 9d3770cd1d3bb6e43a4858e0eb404fa079c1a973

PR 30183 applied with additional changes from upstream: aedb48b0e291dfce2146ad3d86db23b2d69fc084

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 8 subtests

Status Summary

Firefox

OK : 2
FAIL : 16

Chrome

CRASH: 2

Safari

OK : 2
FAIL : 16

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webcodecs/audio-data.any.worker.html
Verify AudioData constructors: FAIL (Safari: FAIL)
Verify closing and cloning AudioData: FAIL (Safari: FAIL)
Test we can construct AudioData with a negative timestamp.: FAIL (Safari: FAIL)
Test conversion of uint8 data to float32: FAIL (Safari: FAIL)
Test conversion of int16 data to float32: FAIL (Safari: FAIL)
Test conversion of int32 data to float32: FAIL (Safari: FAIL)
Test conversion of float32 data to float32: FAIL (Safari: FAIL)
Test copying out planar and interleaved data: FAIL (Safari: FAIL)
/webcodecs/audio-data.any.html
Verify AudioData constructors: FAIL (Safari: FAIL)
Verify closing and cloning AudioData: FAIL (Safari: FAIL)
Test we can construct AudioData with a negative timestamp.: FAIL (Safari: FAIL)
Test conversion of uint8 data to float32: FAIL (Safari: FAIL)
Test conversion of int16 data to float32: FAIL (Safari: FAIL)
Test conversion of int32 data to float32: FAIL (Safari: FAIL)
Test conversion of float32 data to float32: FAIL (Safari: FAIL)
Test copying out planar and interleaved data: FAIL (Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/72dedcc4112b
[wpt PR 30183] - Reject AudioData invalid indexes, a=testonly
https://hg.mozilla.org/integration/autoland/rev/8a0c235206a1
[wpt PR 30183] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/72dedcc4112b
https://hg.mozilla.org/mozilla-central/rev/8a0c235206a1

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox93: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.