1727753 - Ogg file audio/ogg is not displayed in Network Monitor when media switch is used

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[Mikhail]

Attachment: firefox-media-1.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

I have watched requests on a web page. I tried to select media files by clicking on the "media" switch. Ogg files (content-type audio/ogg) are not displayed when the "media" filter is on, these files are displayed only when "all" or "other" is selected.
This does not happen when I watch requests a file with the "mp3" extension (content-type audio/mpeg). When I select the "media" switch I can see audio/mpeg requests in the list.

The attached image shows the request that returns audio/ogg content-type from the initiator "media". If I select the "media" switch (red between "Images" and "WS"), then this request will not appear in the list. (Some private headers are masked.)

Tested еnvironment:
Firefox nightly: 93.0a1 default profile.
Windows: 7 SP1

Actual results:

• audio/ogg requests are not displayed in the list when the "media" switch is used
• audio/ogg requests are displayed in the list when the "other" switch is used

Expected results:

• audio requests should show up in the list when the "media" switch is used

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thank you for the report!

STRs:

1. Load http://janodvarko.cz/tests/bugzilla/1727753/
2. Open DevTools and select the Network panel, reload
3. You should see 'audio.ogg' request
4. Filter the content by pressing the "Media" filter button in the toolbar
5. The media file should be visible and it isn't -> BUG

This might be good first bug. Some instructions for those who are interested in fixing this

• Here is where the Network panel renders the filter buttons
  https://searchfox.org/mozilla-central/rev/5a362eb7d054740dc9d7c82c79a2efbc5f3e4776/devtools/client/netmonitor/src/components/Toolbar.js#400-416

• Here is the React "action" that is fired when one of the filter buttons is pressed
  https://searchfox.org/mozilla-central/rev/5a362eb7d054740dc9d7c82c79a2efbc5f3e4776/devtools/client/netmonitor/src/actions/filters.js#20-25

• Here is the React "reducer" storing the current filter state
  https://searchfox.org/mozilla-central/rev/5a362eb7d054740dc9d7c82c79a2efbc5f3e4776/devtools/client/netmonitor/src/reducers/filters.js

• Here is the "isMedia" selector (predicate) used to filter all media files
  https://searchfox.org/mozilla-central/rev/5a362eb7d054740dc9d7c82c79a2efbc5f3e4776/devtools/client/netmonitor/src/utils/filter-predicates.js#60-70

This function seems to be testing "audio/" prefix, but from some reason the file doesn't make it to the UI

• Here is where we call the filter function
  https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/selectors/requests.js#66-77
  (look also at other functions in this file)

The bug should be somewhere along the lines.

Honza

Comment 2

[Nadinda Rachmat [:nadinda]]

Hi, I am an outreachy applicant. Can I try to work on this bug? Thank you.

Comment 3

[Hubert Boma Manilla (:bomsy)]

Sure assigned to you.

Thanks

Comment 4

[Nadinda Rachmat [:nadinda]]

Attachment: Bug 1727753 - [devtools] Ogg file request is not displayed in Network tab when media tab is selected r=Honza

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

SOW:

• A patch that fixes the problem is attached
• An automated tests is needed (see some pointers here)

Still feels like a good first bug.

Comment 7

[manekenpix]

Hi, can I give this one a go?

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Yes please, assigned tou you, thank you for helping.

Comment 9

[manekenpix]

Attachment: Bug 1727753 - [devtools] Ogg file request is not displayed in Network Monitor when media switch is selected r=Honza

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/afa65eb31134

Comment 11

[Alexandru Trif, Desktop QA [:atrif]]

Reproduced the issue with Firefox 93.0a1 (20210830162701) on Windows 10x64 following STR from comment 1. Filtering by Media inside the Devtools > Network does not show any results.
The issue is verified fixed with Firefox 104.0b2 on Windows 10x64, macOS 11 and Ubuntu 20.04. Filtering by Media inside the Devtools > Network correctly shows the audio.ogg request if present.