1727762 - Compile error in ProfilerThreadRegistrationData.h: expected identifier / comparison between pointer and integer

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P1)

Description

[Robert Mader [:rmader]]

Since bug 1722261 I get a compile error when compiling locally - even after multiple mach clobber and mach boostrap runs. Reverting bug 1722261 works around the issue.

This is my mozconfig:

ac_add_options --enable-debug
ac_add_options --disable-tests
ac_add_options --with-ccache=sccache 
ac_add_options --with-ccache=$HOME/.mozbuild/sccache/sccache

The error is:

39:15.35 In file included from Unified_cpp_layout_forms0.cpp:11:
39:15.35 In file included from /home/robert/firefox/gecko-dev/layout/forms/nsCheckboxRadioFrame.cpp:11:
39:15.35 In file included from /home/robert/firefox/gecko-dev/obj-x86_64-pc-linux-gnu/dist/include/mozilla/dom/HTMLInputElement.h:19:
39:15.35 In file included from /home/robert/firefox/gecko-dev/obj-x86_64-pc-linux-gnu/dist/include/mozilla/dom/Promise.h:22:
39:15.35 In file included from /home/robert/firefox/gecko-dev/obj-x86_64-pc-linux-gnu/dist/include/mozilla/dom/AutoEntryScript.h:16:
39:15.35 In file included from /home/robert/firefox/gecko-dev/obj-x86_64-pc-linux-gnu/dist/include/mozilla/ProfilerLabels.h:14:
39:15.35 In file included from /home/robert/firefox/gecko-dev/obj-x86_64-pc-linux-gnu/dist/include/mozilla/ProfilerThreadState.h:14:
39:15.35 In file included from /home/robert/firefox/gecko-dev/obj-x86_64-pc-linux-gnu/dist/include/mozilla/ProfilerThreadRegistration.h:11:
39:15.35 /home/robert/firefox/gecko-dev/obj-x86_64-pc-linux-gnu/dist/include/mozilla/ProfilerThreadRegistrationData.h:160:5: error: expected identifier
39:15.35     ACTIVE = 2,
39:15.35     ^
39:15.35 /home/robert/firefox/gecko-dev/layout/forms/nsButtonFrameRenderer.cpp:25:16: note: expanded from macro 'ACTIVE'
39:15.35 #define ACTIVE "active"
39:15.35                ^
39:15.35 In file included from Unified_cpp_layout_forms0.cpp:11:
39:15.35 In file included from /home/robert/firefox/gecko-dev/layout/forms/nsCheckboxRadioFrame.cpp:11:
39:15.35 In file included from /home/robert/firefox/gecko-dev/obj-x86_64-pc-linux-gnu/dist/include/mozilla/dom/HTMLInputElement.h:19:
39:15.35 In file included from /home/robert/firefox/gecko-dev/obj-x86_64-pc-linux-gnu/dist/include/mozilla/dom/Promise.h:22:
39:15.35 In file included from /home/robert/firefox/gecko-dev/obj-x86_64-pc-linux-gnu/dist/include/mozilla/dom/AutoEntryScript.h:16:
39:15.35 In file included from /home/robert/firefox/gecko-dev/obj-x86_64-pc-linux-gnu/dist/include/mozilla/ProfilerLabels.h:14:
39:15.35 In file included from /home/robert/firefox/gecko-dev/obj-x86_64-pc-linux-gnu/dist/include/mozilla/ProfilerThreadState.h:14:
39:15.35 In file included from /home/robert/firefox/gecko-dev/obj-x86_64-pc-linux-gnu/dist/include/mozilla/ProfilerThreadRegistration.h:11:
39:15.35 /home/robert/firefox/gecko-dev/obj-x86_64-pc-linux-gnu/dist/include/mozilla/ProfilerThreadRegistrationData.h:432:36: error: comparison between pointer and integer ('enum (anonymous enum at /home/robert/firefox/gecko-dev/obj-x86_64-pc-linux-gnu/dist/include/mozilla/ProfilerThreadRegistrationData.h:157:3)' and 'const char *')
39:15.35     MOZ_RELEASE_ASSERT(mJSSampling == ACTIVE ||

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Thanks for the report. I was able to reproduce it.
As I guessed from your log, this #define ACTIVE must be affecting #includes in a later file, due to the unified build.
This group of #defines looks obsolete anyway, dating from 1999, but not used in this file anymore! I'll remove them.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1727762 - Fix profiler build issue by removing obsolete macros in nsButtonFrameRenderer.cpp - r?mstange

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/785194c6badc
Fix profiler build issue by removing obsolete macros in nsButtonFrameRenderer.cpp - r=mstange

Comment 4

[Robert Mader [:rmader]]

Thanks for the quick reaction!

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/785194c6badc

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1722261