1727781 - [wpt-sync] Sync PR 30197 - Stack-overflow in blink::IsSpaceLike

Status: RESOLVED FIXED

(Core :: MathML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 30197 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30197
Details from upstream follow.

b'Fr\xc3\xa9d\xc3\xa9ric Wang <[e-mail]>' wrote:

Stack-overflow in blink::IsSpaceLike

The IsSpaceLike and GetCoreOperator functions receive a NGBlockNode node
parameter. When it corresponds to a grouping element or an \<mpadded>
element in the DOM tree, then these functions browse its children,
casting each one to a NGBlockNode. This works for the grouping/\<mpadded>
elements with math display (since they blockify their children) but may
hit "Security DCHECK failed: IsA\<Derived>(from)" for other display
values. To address that issue, an early exit is added in IsSpaceLike
similar to the one that already exists in GetCoreOperator. See [1] for
the related specification discussion.

[1] https://github.com/w3c/mathml-core/issues/108

Bug: 1243691, 6606, 1124298
Change-Id: I4ddd4d57b20ffce0e6ef6fd2cf478b8c77363440

Reviewed-on: https://chromium-review.googlesource.com/3122134
WPT-Export-Revision: 3c40bf54247298f73c54d7b163fbc3b5b8471eca

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae930e075a7d5a9d07c8fd8000cf721bdcf40adc

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c9a96f05236
[wpt PR 30197] - Stack-overflow in blink::IsSpaceLike, a=testonly

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/0c9a96f05236