Closed Bug 1727794 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30198 - [LayoutNG] Add virtual test suite for flex fragmentation support

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
93 Branch
Tracking Flags:
Tracking Status
firefox93 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30198 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30198
Details from upstream follow.

b'Alison Maher <almaher@microsoft.com>' wrote:

[LayoutNG] Add virtual test suite for flex fragmentation support

We currently fall back to legacy layout when encountering a flexbox
inside a multicol. That logic was updated to skip the fallback if
LayoutNGFlexFragmentation is enabled.

This CL also adds a virtual test suite for LayoutNGFlexFragmentation.
Because the implementation is not yet in place, relevant tests crash
as a result (see the updated TestExpectations).

Flexbox related tests in fast/multicol were moved to fast/multicol/fixed
to scope the test suite down and avoid repetition with the
layout_ng_block_frag virtual test suite.

There is one test in external/wpt/css/css-multicol that will now crash
with LayoutNGFlexFragmentation enabled: multicol-span-all-005.html.
However, since that test is failing in general, and no other relevant
tests existed in external/wpt/css/css-multicol, that directory was not
included in the layout_ng_flex_frag test suite.

Bug: 660611
Change-Id: I30b89471195f073b9e661e123db744e7132bb124
Reviewed-on: https://chromium-review.googlesource.com/3120327
WPT-Export-Revision: 3f1d3357b44729891a8abdc3e898e1dec829ae32

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

PASS: 2

Safari

PASS: 2

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/202adc6a4b28
[wpt PR 30198] - [LayoutNG] Add virtual test suite for flex fragmentation support, a=testonly

https://hg.mozilla.org/mozilla-central/rev/202adc6a4b28

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox93: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.