1727829 - Consider to not initialize AboutReaderChild actor for initial about:blank documents when pagehide fires

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, enhancement, P2)

Description

[Olli Pettay [:smaug][[e-mail]]]

Currently AboutReaderChild does show up in the performance profiles because of pagehide handling. We should consider to stop initializing the actor during pagehide.

Patch coming

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1727829 - Consider to not initialize AboutReaderChild actor for initial about:blank documents when pagehide fires, r=NeilDeakin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4195038b8549
Consider to not initialize AboutReaderChild actor for initial about:blank documents when pagehide fires, r=NeilDeakin

Comment 3

[Iulian Moraru]

Backed out for causing bc failures on browser_ext_tabs_onUpdated_filter.js.

Push with failures

Failure log

Backout link

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Aha, the failure isn't the same as in bug 1713432.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91cd14a39722
Consider to not initialize AboutReaderChild actor for initial about:blank documents when pagehide fires, r=NeilDeakin

Comment 6

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (Bug 1727829, Bug 1728371) for causing bc failures in browser_ext_windows_create_tabId.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/c10e2f9e170982f2089b944299fe69889be29242
Push with failures, failure log.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b21557eeb0e5
Consider to not initialize AboutReaderChild actor for initial about:blank documents when pagehide fires, r=NeilDeakin

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b21557eeb0e5

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Clearing the leftover needinfo.