Closed Bug 1727829 Opened 1 year ago Closed 1 year ago

Consider to not initialize AboutReaderChild actor for initial about:blank documents when pagehide fires

Categories

(Toolkit :: Reader Mode, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
94 Branch
Tracking Status
firefox94 --- fixed

People

(Reporter: smaug, Assigned: smaug, NeedInfo)

References

Details

Attachments

(1 file)

Currently AboutReaderChild does show up in the performance profiles because of pagehide handling. We should consider to stop initializing the actor during pagehide.

Patch coming

Summary: Consider to not initialize AboutReaderChild actor for initial about:blank documents → Consider to not initialize AboutReaderChild actor for initial about:blank documents whne pagehide fires
Summary: Consider to not initialize AboutReaderChild actor for initial about:blank documents whne pagehide fires → Consider to not initialize AboutReaderChild actor for initial about:blank documents when pagehide fires
Severity: -- → S3
Priority: -- → P2
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4195038b8549
Consider to not initialize AboutReaderChild actor for initial about:blank documents when pagehide fires, r=NeilDeakin

Backed out for causing bc failures on browser_ext_tabs_onUpdated_filter.js.

Push with failures

Failure log

Backout link

Flags: needinfo?(bugs)

Aha, the failure isn't the same as in bug 1713432.

Flags: needinfo?(bugs)
Depends on: 1728371
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/91cd14a39722
Consider to not initialize AboutReaderChild actor for initial about:blank documents when pagehide fires, r=NeilDeakin

Backed out 2 changesets (Bug 1727829, Bug 1728371) for causing bc failures in browser_ext_windows_create_tabId.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/c10e2f9e170982f2089b944299fe69889be29242
Push with failures, failure log.

Flags: needinfo?(bugs)
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b21557eeb0e5
Consider to not initialize AboutReaderChild actor for initial about:blank documents when pagehide fires, r=NeilDeakin
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.