172783 - crashes printing any email [@ nsPrintingPromptService::OnStateChange]

Status: RESOLVED FIXED

(Core :: Printing: Output, defect, P1)

Description

[Andrew Schultz]

If I try to print any email message, Mozilla crashes.  It seemed to be limited
to plaintext, but now I crash printing any email.

linux trunk build 2002100208 does not crash.  2002100308 does crash.
linux trunk build 2002100421 still crashes.

bonsai says mailnews printing got shook up pretty good during that window (bug
158110)

debug build give approximately 2.5 billion of these:
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'JavaScript component does not have a method named:
"getImageSource"' when calling method:
[nsIXULTreeBuilderObserver::getImageSource]"  nsresult: "0x80570030
(NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)"  location: "<unknown>"  data: no]
************************************************************
and then
###!!! ASSERTION: aWidgetView must have a widget: 'nsnull != widget', file
nsViewManager.cpp, line 1548
WEBSHELL- = 6
###!!! ASSERTION: You can't dereference a NULL nsCOMPtr with operator->().:
'mRawPtr != 0', file ../../../../../dist/include/xpcom/nsCOMPtr.h, line 650

Comment 1

[Andrew Schultz]

Attachment: stacktrace

mPrintProgress is NULL

Comment 2

[Andrew Schultz]

further investigation shows that the JS Exception is Mailnews' fault.  it spews
that all the time.

Comment 3

[rods (gone)]

Attachment: patch v1

When I fixed windows I should have fixed Linux. Simple just make sure it isn't
null befopre referenceing it. (on my S drive)

Comment 4

[rods (gone)]

Attachment: patch v2 (mac, unixshared, os2)

Almost made the same mistake twice, here is the same patch that is on Windows
for mac, unixshared and os2

Comment 5

[Andrew Schultz]

is bug 172753 (probably) a dupe then?

Comment 6

[dcone (gone)]

Comment on attachment 101978 [details] [diff] [review]
patch v2 (mac, unixshared, os2)

r=dcone

Comment 7

[rods (gone)]

Andrew, I guess in a way it is....

Comment 8

[kinmoz]

Comment on attachment 101978 [details] [diff] [review]
patch v2 (mac, unixshared, os2)

sr=[e-mail]

Comment 9

[David G King]

*** Bug 172867 has been marked as a duplicate of this bug. ***

Comment 10

[David G King]

I've just marked Bug #172867 as a dup as it reports the same error, but it
happens when you select Window-Mail&Newsgroups.

Also, OS and PLATFORM should be ALL.

Comment 11

[Andrew Schultz]

*** Bug 173143 has been marked as a duplicate of this bug. ***

Comment 12

[rods (gone)]

fixed

Comment 13

[Greg K.]

*** Bug 172753 has been marked as a duplicate of this bug. ***

Comment 14

[David G King]

*** Bug 172867 has been marked as a duplicate of this bug. ***

Comment 15

[Shanmugavelu Shanmuganathan (gone)]

Attachment: Tru64 UNIX's stack trace

Comment 16

[Shanmugavelu Shanmuganathan (gone)]

I still see the crash on a Tru64 UNIX.
Stack trace is attched with comment #15.

Comment 17

[Andrew Schultz]

you're seeing 173519

Comment 18

[Greg K.]

*** Bug 167555 has been marked as a duplicate of this bug. ***