Closed Bug 1727864 Opened 3 years ago Closed 2 years ago

[wpt-sync] Sync PR 30208 - Migrate cookie-test.js's httpCookieTest to test_driver.delete_all_cookies

Categories

(Core :: Networking: Cookies, task, P4)

Product:
Core
Component:
Networking: Cookies
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
97 Branch
Tracking Flags:
Tracking Status
firefox97 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Notable wpt changes
71.36 KB, text/plain
Details

Sync web-platform-tests PR 30208 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30208
Details from upstream follow.

b'Ari Chivukula <arichiv@chromium.org>' wrote:

Migrate cookie-test.js's httpCookieTest to test_driver.delete_all_cookies

Now that we have a JS function within testdriver to delete all cookies
we should use it instead of the one-off helpers.

Bug: 1233305
Change-Id: Ifa53b1cf3a392b92f9e1c7cdc84be3001e3a89a9
Reviewed-on: https://chromium-review.googlesource.com/3116688
WPT-Export-Revision: 372f97012282d19eddc53d9672a8136b61c48e00

PR 30208 applied with additional changes from upstream: 640dc9dec7531b09cc54cb18c0fc91b03df0ccb2, 5adb81b4ec4089523f47aaba2c2907621686f405
Component: web-platform-tests → Networking: Cookies
Product: Testing → Core
Attached file Notable wpt changes — 
# CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 20 tests and 429 subtests

## Status Summary

### Firefox
OK     : 18[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-qr-debug, Gecko-windows10-32-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 19[GitHub]
PASS   : 275[GitHub] 370[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-qr-debug, Gecko-windows10-32-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt]
FAIL   : 132[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-qr-debug, Gecko-windows10-32-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 500[GitHub]
TIMEOUT: 1
ERROR  : 1

### Chrome
OK     : 19
PASS   : 709
FAIL   : 59
ERROR  : 1

### Safari
OK     : 19
PASS   : 347
FAIL   : 422
TIMEOUT: 2
NOTRUN : 6

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=b43693ceae8474564fda439ac5bc406c78a1e60c)
[GitHub PR Head](https://wpt.fyi/results/?sha=364d8c0e449cc7e850d1e80065a1135d72f06d8c&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=364d8c0e449cc7e850d1e80065a1135d72f06d8c&label=pr_base)

## Details

### Firefox-only Failures
/cookies/attributes/invalid.html
  Ignore `Set-Cookie: =`: FAIL
  Ignore empty cookie string: FAIL
  Ignore cookie with domain that won't domain match (along with other invalid noise): FAIL
/cookies/attributes/max-age.html
  Don't set multiple cookies with max-age=0: FAIL
/cookies/attributes/path-redirect.html
  No cookie sent for redirected path mismatch with trailing '?' after unquoted Path: FAIL
  No cookie sent for redirected path mismatch with trailing '#' after unquoted Path: FAIL
/cookies/attributes/path.html
  Set cookie for mismatched and root path: FAIL
  Return cookie for path= / (whitespace after equals): FAIL
/cookies/name/name-ctl.html
  Cookie with %x7f in name is rejected.: FAIL
/cookies/name/name.html
  Remove trailing WSP characters from the name string: FAIL
  Remove leading WSP characters from the name string: FAIL
  Only return the new cookie (with the same name): FAIL
  Ignore invalid attributes after valid name (that looks like Cookie2 Version attribute): FAIL
  Set a cookie that has whitespace in its name: FAIL
  Use last value for cookies with identical names: FAIL
  Keep first-in, first-out name order: FAIL
  Keep first-in, first-out single-char name order: FAIL
  Ignore cookie with empty name and empty value: FAIL
  Ignore cookie with no name or value: FAIL
  URL-encoded cookie name is not decoded: FAIL
  Name is set as expected for a=test: FAIL
  Name is set as expected for 1=test: FAIL
  Name is set as expected for $=test: FAIL
  Name is set as expected for !a=test: FAIL
  Name is set as expected for @a=test: FAIL
  Name is set as expected for #a=test: FAIL
  Name is set as expected for $a=test: FAIL
  Name is set as expected for %a=test: FAIL
  Name is set as expected for ^a=test: FAIL
  Name is set as expected for &a=test: FAIL
  Name is set as expected for *a=test: FAIL
  Name is set as expected for (a=test: FAIL
  Name is set as expected for )a=test: FAIL
  Name is set as expected for -a=test: FAIL
  Name is set as expected for _a=test: FAIL
  Name is set as expected for +=test: FAIL
  Name is set as expected for "a=test: FAIL
/cookies/path/default.html: ERROR
  Test for default cookie path: TIMEOUT
/cookies/size/attributes.www.sub.html
  Max size path attribute (1024 bytes) is not ignored: FAIL
/cookies/size/name-and-value.html
  Set max-size cookie with largest possible name and value (4096 bytes): FAIL
  Ignore cookie with name larger than 4096 and 1 byte value: FAIL
  Set max-size value-less cookie: FAIL
  Ignore value-less cookie with name larger than 4096 bytes: FAIL
  Set max-size cookie with largest possible value (4095 bytes): FAIL
  Ignore named cookie (with non-zero length) and value larger than 4095 bytes: FAIL
  Ignore named cookie with length larger than 4095 bytes, and a non-zero value: FAIL
  Ignore name-less cookie with value larger than 4096 bytes: FAIL
  Ignore name-less cookie (without leading =) with value larger than 4096 bytes: FAIL
  Set max-size cookie that also has an attribute: FAIL
/cookies/value/value.html
  Set value with unbalanced leading quote: FAIL
  Set cookie but ignore value after LF: FAIL
  Set cookie ignoring whitespace after value endquote: FAIL
  Ignore whitespace and ; after value: FAIL
  Ignore whitespace preceding value: FAIL
  Set cookie with quotes in value: FAIL
  Set cookie keeping whitespace inside quoted value: FAIL
  Set cookie with another = inside quoted value: FAIL
  Set cookie ignoring whitespace surrounding value and characters after first semicolon: FAIL
  URL-encoded cookie value is not decoded: FAIL
  Ignore whitespace at the end of value: FAIL
  Set cookie with large name + value ( = 4kb): FAIL
  Ignore cookie with large name + value ( > 4kb): FAIL
  Set cookie with value set to =: FAIL
  Set cookie with one = inside an unquoted value: FAIL
  Set cookie with two = inside an unquoted value: FAIL
  Set cookie with a space character in the value: FAIL
/cookies/attributes/attributes-ctl.sub.html
  Cookie with %x0 in Domain attribute value is handled correctly.: FAIL
  Cookie with %x0 in Path attribute value is handled correctly.: FAIL
  Cookie with %x1 in Domain attribute value is handled correctly.: FAIL
  Cookie with %x1 in Path attribute value is handled correctly.: FAIL
  Cookie with %x1 after Secure attribute is handled correctly.: FAIL
  Cookie with %x2 in Domain attribute value is handled correctly.: FAIL
  Cookie with %x2 in Path attribute value is handled correctly.: FAIL
  Cookie with %x2 after Secure attribute is handled correctly.: FAIL
  Cookie with %x3 in Domain attribute value is handled correctly.: FAIL
  Cookie with %x3 in Path attribute value is handled correctly.: FAIL
  Cookie with %x3 after Secure attribute is handled correctly.: FAIL
  Cookie with %x4 in Domain attribute value is handled correctly.: FAIL
  Cookie with %x4 in Path attribute value is handled correctly.: FAIL
  Cookie with %x4 after Secure attribute is handled correctly.: FAIL
  Cookie with %x5 in Domain attribute value is handled correctly.: FAIL
  Cookie with %x5 in Path attribute value is handled correctly.: FAIL
  Cookie with %x5 after Secure attribute is handled correctly.: FAIL
  Cookie with %x6 in Domain attribute value is handled correctly.: FAIL
  Cookie with %x6 in Path attribute value is handled correctly.: FAIL
  Cookie with %x6 after Secure attribute is handled correctly.: FAIL
  Cookie with %x7 in Domain attribute value is handled correctly.: FAIL
  Cookie with %x7 in Path attribute value is handled correctly.: FAIL
  Cookie with %x7 after Secure attribute is handled correctly.: FAIL
  Cookie with %x8 in Domain attribute value is handled correctly.: FAIL
  Cookie with %x8 in Path attribute value is handled correctly.: FAIL
  Cookie with %x8 after Secure attribute is handled correctly.: FAIL
  Cookie with %xb in Domain attribute value is handled correctly.: FAIL
  Cookie with %xb in Path attribute value is handled correctly.: FAIL
  Cookie with %xb after Secure attribute is handled correctly.: FAIL
  Cookie with %xc in Domain attribute value is handled correctly.: FAIL
  Cookie with %xc in Path attribute value is handled correctly.: FAIL
  Cookie with %xc after Secure attribute is handled correctly.: FAIL
  Cookie with %xe in Domain attribute value is handled correctly.: FAIL
  Cookie with %xe in Path attribute value is handled correctly.: FAIL
  Cookie with %xe after Secure attribute is handled correctly.: FAIL
  Cookie with %xf in Domain attribute value is handled correctly.: FAIL
  Cookie with %xf in Path attribute value is handled correctly.: FAIL
  Cookie with %xf after Secure attribute is handled correctly.: FAIL
  Cookie with %x10 in Domain attribute value is handled correctly.: FAIL
  Cookie with %x10 in Path attribute value is handled correctly.: FAIL
  Cookie with %x10 after Secure attribute is handled correctly.: FAIL
  Cookie with %x11 in Domain attribute value is handled correctly.: FAIL
  Cookie with %x11 in Path attribute value is handled correctly.: FAIL
  Cookie with %x11 after Secure attribute is handled correctly.: FAIL
  Cookie with %x12 in Domain attribute value is handled correctly.: FAIL
  Cookie with %x12 in Path attribute value is handled correctly.: FAIL
  Cookie with %x12 after Secure attribute is handled correctly.: FAIL
  Cookie with %x13 in Domain attribute value is handled correctly.: FAIL
  Cookie with %x13 in Path attribute value is handled correctly.: FAIL
  Cookie with %x13 after Secure attribute is handled correctly.: FAIL
  Cookie with %x14 in Domain attribute value is handled correctly.: FAIL
  Cookie with %x14 in Path attribute value is handled correctly.: FAIL
  Cookie with %x14 after Secure attribute is handled correctly.: FAIL
  Cookie with %x15 in Domain attribute value is handled correctly.: FAIL
  Cookie with %x15 in Path attribute value is handled correctly.: FAIL
  Cookie with %x15 after Secure attribute is handled correctly.: FAIL
  Cookie with %x16 in Domain attribute value is handled correctly.: FAIL
  Cookie with %x16 in Path attribute value is handled correctly.: FAIL
  Cookie with %x16 after Secure attribute is handled correctly.: FAIL
  Cookie with %x17 in Domain attribute value is handled correctly.: FAIL
  Cookie with %x17 in Path attribute value is handled correctly.: FAIL
  Cookie with %x17 after Secure attribute is handled correctly.: FAIL
  Cookie with %x18 in Domain attribute value is handled correctly.: FAIL
  Cookie with %x18 in Path attribute value is handled correctly.: FAIL
  Cookie with %x18 after Secure attribute is handled correctly.: FAIL
  Cookie with %x19 in Domain attribute value is handled correctly.: FAIL
  Cookie with %x19 in Path attribute value is handled correctly.: FAIL
  Cookie with %x19 after Secure attribute is handled correctly.: FAIL
  Cookie with %x1a in Domain attribute value is handled correctly.: FAIL
  Cookie with %x1a in Path attribute value is handled correctly.: FAIL
  Cookie with %x1a after Secure attribute is handled correctly.: FAIL
  Cookie with %x1b in Domain attribute value is handled correctly.: FAIL
  Cookie with %x1b in Path attribute value is handled correctly.: FAIL
  Cookie with %x1b after Secure attribute is handled correctly.: FAIL
  Cookie with %x1c in Domain attribute value is handled correctly.: FAIL
  Cookie with %x1c in Path attribute value is handled correctly.: FAIL
  Cookie with %x1c after Secure attribute is handled correctly.: FAIL
  Cookie with %x1d in Domain attribute value is handled correctly.: FAIL
  Cookie with %x1d in Path attribute value is handled correctly.: FAIL
  Cookie with %x1d after Secure attribute is handled correctly.: FAIL
  Cookie with %x1e in Domain attribute value is handled correctly.: FAIL
  Cookie with %x1e in Path attribute value is handled correctly.: FAIL
  Cookie with %x1e after Secure attribute is handled correctly.: FAIL
  Cookie with %x1f in Domain attribute value is handled correctly.: FAIL
  Cookie with %x1f in Path attribute value is handled correctly.: FAIL
  Cookie with %x1f after Secure attribute is handled correctly.: FAIL
  Cookie with %x7f in Domain attribute value is handled correctly.: FAIL
  Cookie with %x7f in Path attribute value is handled correctly.: FAIL
  Cookie with %x7f after Secure attribute is handled correctly.: FAIL

(See attachment for full changes)
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6c8564de86ad
[wpt PR 30208] - Migrate cookie-test.js's httpCookieTest to test_driver.delete_all_cookies, a=testonly
https://hg.mozilla.org/integration/autoland/rev/5890ec9e20cc
[wpt PR 30208] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/6c8564de86ad
https://hg.mozilla.org/mozilla-central/rev/5890ec9e20cc

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox97: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: