1727913 - should not be able to edit event title inline for meeting invitations

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[adrien.rybarczyk]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.100 Safari/537.36

Steps to reproduce:

1. Have a remote calendar.
2. Get invited to an event.
3. Double click on the event slowly to edit the title directly from the calendar view.
4. Change the title and validate with enter.

Actual results:

The title will be changed.
Whereas if we open the event, we cannot modify it.

Expected results:

Not being able to change the title for events where you are invited.

Comment 1

[adrien.rybarczyk]

Attachment: openEventBeforeModify.PNG

Comment 2

[adrien.rybarczyk]

Attachment: modifyName.png

Comment 3

[adrien.rybarczyk]

Attachment: openEventAfterModify.PNG

Comment 4

[adrien.rybarczyk]

Attachment: notification.PNG

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug is invalid.
If you think the bot is wrong, please reopen the bug and move it back to its prior component.

Be aware this is a production bug database used by the Mozilla community to develop Firefox, and other products.
Filing test bugs here wastes the time of all our contributors, volunteers, as well as paid employees.
If you continue to abuse bugzilla.mozilla.org your account will be disabled.

Comment 6

[adrien.rybarczyk]

Still present in TB 95.0b3

Comment 7

[Lasana Murray]

I agree.

Comment 8

[Lasana Murray]

Attachment: Bug 1727913 : Do not allow invitations to be edited via slow double click. r=aleca

Comment 9

[Alessandro Castellani [:aleca]]

Nice improvement.
This issue happens also with all day events I didn't create.
We should prevent inline editing of titles for events that haven't been created by the user.

Comment 10

[Lasana Murray]

(In reply to Alessandro Castellani [:aleca] from comment #9)

We should prevent inline editing of titles for events that haven't been created by the user.

Interesting. If the user has write access to the calendar they are allowed to edit any events they choose except invitations (but only in the UI).
Or did you mean an all day event on a read-only calendar?

Comment 11

[Alessandro Castellani [:aleca]]

(In reply to Lasana Murray from comment #10)

Interesting. If the user has write access to the calendar they are allowed to edit any events they choose except invitations (but only in the UI).
Or did you mean an all day event on a read-only calendar?

Mhhh, interesting indeed.

So, if I (user) own the remote calendar and I receive an invite from another user and save that invite into my remote calendar, should I be allowed to edit the event information?

I guess I should, since the invite was saved in my remote calendar, even tho I didn't create that event.

Comment 12

[Lasana Murray]

(In reply to Alessandro Castellani [:aleca] from comment #11)

...
So, if I (user) own the remote calendar and I receive an invite from another user and save that invite into my remote calendar, should I be allowed to edit the event information?

If you "accepted/tentative/declined" the event then I don't think so. At least not the pertinent event details (you can add a reminder for yourself to the event). If the user created the event on a calendar you own however, then it's kind of still "your" event.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0facf60cf15e
Do not allow invitations to be edited via slow double click. r=aleca

Comment 14

[Lasana Murray]

Comment on attachment 9278400 [details]
Bug 1727913 : Do not allow invitations to be edited via slow double click. r=aleca

[Approval Request Comment]
Regression caused by (bug #): None
User impact if declined: They will be able to edit things they should not.
Testing completed (on c-c, etc.): 103
Risk to taking this patch (and alternatives if risky): Low risk

Comment 15

[Wayne Mery (:wsmwk)]

Comment on attachment 9278400 [details]
Bug 1727913 : Do not allow invitations to be edited via slow double click. r=aleca

[Triage Comment]
Approved for beta

Comment 16

[Rob Lemley [:rjl]]

Thunderbird 102.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/73c97768cde3