Closed Bug 1727933 Opened 4 years ago Closed 4 years ago

Autocomplete fails if the only result is that from an extension

Categories

(Thunderbird :: Add-Ons: Extensions API, defect)

Product:
Thunderbird
Component:
Add-Ons: Extensions API
Version:
Thunderbird 90
Type:
defect

Tracking

(thunderbird_esr91+ fixed, thunderbird92 wontfix)

Status:
RESOLVED FIXED
Milestone:
93 Branch
Tracking Flags:
Tracking Status
thunderbird_esr91 + fixed
thunderbird92 --- wontfix

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file)

Proposed patch
1.06 KB, patch
darktrojan
: review+
wsmwk
: approval-comm-esr91+
Details | Diff | Splinter Review

If there is exactly one autocomplete result, and this result was provided by an extension using the addressbook.provider API, the result does not actually show up. If there are multiple results for any reason, the results all show up as expected.

Attached patch Proposed patch — — Splinter Review
Attachment #9238329 - Flags: review?(geoff)
Attachment #9238329 - Flags: review?(geoff) → review+
Status: NEW → ASSIGNED
status-thunderbird92: --- → wontfix
status-thunderbird_esr91: --- → affected
tracking-thunderbird_esr91: --- → +
Keywords: checkin-needed-tb
Target Milestone: --- → 93 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/3e26db670fb8
Extension results need a default index r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED
Attachment #9238329 - Flags: approval-comm-esr91?
Attachment #9238329 - Flags: approval-comm-beta?

Comment on attachment 9238329 [details] [diff] [review]
Proposed patch

[Triage Comment]
Approved for esr91

(already on beta, so removing flag)

Attachment #9238329 - Flags: approval-comm-esr91?
Attachment #9238329 - Flags: approval-comm-esr91+
Attachment #9238329 - Flags: approval-comm-beta?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: