Closed Bug 1728052 Opened 3 months ago Closed 3 months ago

[wpt-sync] Sync PR 30222 - Revert "Reland "Populate pointerId, pointerType for contextmenu event""

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox93 fixed)

RESOLVED FIXED
93 Branch
Tracking Status
firefox93 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30222 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30222
Details from upstream follow.

b'Yuki Shiino <yukishiino@chromium.org>' wrote:

Revert "Reland "Populate pointerId, pointerType for contextmenu event""

This reverts commit d02efa408f9e1cdd3299e0068e27f7d54c2061dc.

Reason for revert: Suspicious about causing test failures of
external/wpt/pointerevents/pointerevent_contextmenu_is_a_pointerevent.html?touch
https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.13%20Tests/41310/overview

Original change's description:

Reland "Populate pointerId, pointerType for contextmenu event"

This is a reland of a6d69d5243dd02afbd8ef02e5a5c557dd8c4a9e9

I believe the reason for the test failures when this landed
the first time was related to how pointerId was populated
for the contextmenu pointer event.
With crrev.com/c/2889205 landed, we have a robust way to
associate the gesture event sequence with the corresponding
pointer event sequence.
This CL uses the approach in crrev.com/c/2889205 to populate
the pointerId for the contextmenu pointer event.

Original change's description:

Populate pointerId, pointerType for contextmenu event

For contextmenu as a pointer event pointerId and pointerType
were not populated.

In this CL we are populating pointerId/pointerType for contextmenu
coming from touch and mouse.
For touch we use a similar approach to crrev.com/c/2800231
for populating pointerId,pointerType for clicks generated in
GestureManager::HandleGestureTap.
The main change will be in EventHandler::SendContextMenuEvent
where we'll be passing id and pointer type to the call to
MouseEventManager::DispatchMouseEvent. This in turn will
populate pointerId and pointerType correctly when the contextmenu
PointerEvent is created.

Bug: 1150442,1150441
TEST: external/wpt/pointerevents/pointerevent_contextmenu_is_a_pointerevent.html
Change-Id: If2408d9cf0d5f00b08efcf2236ff7933472972ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2874026
Commit-Queue: Liviu Tinta \<liviutinta@chromium.org>
Reviewed-by: Robert Flack \<flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881145}

Bug: 1150442,1150441,1207709
Change-Id: Iffaa60373a3811a10f54ff123e64850801450883
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3101585
Commit-Queue: Liviu Tinta \<liviutinta@chromium.org>
Reviewed-by: Mustaq Ahmed \<mustaq@chromium.org>
Reviewed-by: Robert Flack \<flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#916130}

Bug: 1150442,1150441,1207709
Change-Id: Ie5c5ae516f3ed428c25a3d2feac9557fce8755fb

Reviewed-on: https://chromium-review.googlesource.com/3128400
WPT-Export-Revision: b9018acd7327b9ff003822a734acbc54b8e13bfb

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/pointerevents/pointerevent_contextmenu_is_a_pointerevent.html
contextmenu is a PointerEvent: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b10c0dae6dd6
[wpt PR 30222] - Revert "Reland "Populate pointerId, pointerType for contextmenu event"", a=testonly
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.