1728069 - The MarkupView is leaks on each page reload by a dangling 'picker-node-canceled' listener

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Alexandre Poirot [:ochameau]]

We register a "picker-node-canceled" listener on the NodePicker over here:
https://searchfox.org/mozilla-central/rev/5a362eb7d054740dc9d7c82c79a2efbc5f3e4776/devtools/client/inspector/markup/markup.js#318-321

  this.inspector.toolbox.nodePicker.on(
    "picker-node-canceled",
    this._onToolboxPickerCanceled
  );

which we never remove.

But we do instantiate a new MarkupView on each new page load:
https://searchfox.org/mozilla-central/rev/5a362eb7d054740dc9d7c82c79a2efbc5f3e4776/devtools/client/inspector/inspector.js#374

And so we end up leaking each MarkupView instance because of this.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1728069 - [devtools] Avoid leaking the markup view via a dangling listener on node picker.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f278df06ab5
[devtools] Avoid leaking the markup view via a dangling listener on node picker. r=nchevobbe

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/3f278df06ab5