1728092 - Wait properly for toolbox to completely load after a reload in netmonitor tests

Status: RESOLVED FIXED

(DevTools :: Netmonitor, task)

Description

[Hubert Boma Manilla (:bomsy)]

Just doing a waitForNetworkEvents after relaods(for netmonitor tests) in scenarios like

const wait = waitForNetworkEvents(monitor, 1);
tab.linkedBrowser.reload();
await wait;

are not enough and are leading to issues. One possible issue is this fail issue mentioned here
https://bugzilla.mozilla.org/show_bug.cgi?id=1726461

Lets wait for the toolbox to completely load and any necessary events before continuing.

Also the work being done in https://bugzilla.mozilla.org/show_bug.cgi?id=1727506 would be very helpful.

Comment 1

[Julian Descottes [:jdescottes]]

Might be missing some of them, but updating all the tests returned by the following query would be a good start: https://searchfox.org/mozilla-central/search?q=.reload%28%29&path=devtools%2Fclient%2Fnetmonitor&case=false&regexp=false

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1728092 - [devtools] Wait properly for toolbox to completely load after a reload in netmonitor tests

Depends on D124169

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1728092 - [devtools] Use shared browserReload helper in most tests using browser.reload

Depends on D124188

A few tests outside of the netmonitor also used tab.linkedBrowser.reload, let's migrate them at the same time.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98a89c0b759f
[devtools] Wait properly for toolbox to completely load after a reload in netmonitor tests r=bomsy
https://hg.mozilla.org/integration/autoland/rev/a8c44ae83022
[devtools] Use shared browserReload helper in most tests using browser.reload r=bomsy

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/98a89c0b759f
https://hg.mozilla.org/mozilla-central/rev/a8c44ae83022