Closed
Bug 1728138
Opened 3 years ago
Closed 3 years ago
Reuse navigateTo in RDM test helper load
Categories
(DevTools :: Responsive Design Mode, task, P3)
DevTools
Responsive Design Mode
Tracking
(firefox93 fixed)
RESOLVED
FIXED
93 Branch
| Tracking | Status | |
|---|---|---|
| firefox93 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(1 file)
See https://phabricator.services.mozilla.com/D123604#inline-682341
We could start reusing navigateTo directly in RDM's load test helper.
However, the load helper is not always used to reload the selected browser, so navigateTo will have to be updated first in order to support a custom browser element. Right now it assumes we use the selected tab and its linkedBrowser: https://searchfox.org/mozilla-central/rev/5a362eb7d054740dc9d7c82c79a2efbc5f3e4776/devtools/client/shared/test/shared-head.js#473,514
Also in RDM's case the browser is not necessarily the linkedBrowser from the tab, so we might have to support both browser and tab arguments.
|
Assignee | |
Comment 2•3 years ago
|
||
|
||
Updated•3 years ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/013498cd7b8f [devtools] Reuse navigateTo in RDM test helper load r=ochameau
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox93:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•