Removing Nimbus variables for the feature opt-in change
Categories
(Firefox :: Address Bar, enhancement, P2)
Tracking
()
People
(Reporter: nanj, Unassigned)
References
Details
Now that showing the onboarding dialog is mandatory for Firefox Suggest, we should clean up those Nimbus experiment variables to reflect this change.
Specifically, since we should always show the onboarding dialog after the 0th restart. All the calls of UrlbarPrefs.get("quickSuggestShouldShowOnboardingDialog") should now be replaced by UrlbarPrefs.get("quicksuggest.shouldShowOnboardingDialog"). The same applies to quickSuggestShowOnboardingDialogAfterNRestarts.
Natalie, do you believe we'd change this from opt-in to opt-out again in the future, or will we ever want to conduct experiments on that? If the answer is "no", then there is no point in keeping those variables in the Nimbus manifest.
|
Reporter | |
Updated•3 years ago
|
|
|
Reporter | |
Updated•3 years ago
|
|
||
Comment 1•3 years ago
|
||
So this was just decided by Mikal and Legal, but this feature will be Opt-in for only existing users and shown upon a restart. No new users will receive this prompt or get the Online scenario. There are no plans for this to be Opt-out and the chances are low, but future flexibility is good. I'll leave it up to you if you want to clean up because I don't know level of effort.
|
||
Updated•3 years ago
|
|
|
Reporter | |
Comment 2•3 years ago
|
||
Okay, let's leave those variables alone then.
No new users will receive this prompt or get the Online scenario.
Are you sure we don't want to show Firefox Suggest (Online) to the users with new profiles? FWIW, we don't have this targeting configured on Nimbus.
|
|
||
Comment 3•3 years ago
|
||
Yes, that's correct. It's direction from legal. I'll post in slack for more visibility
| Comment hidden (spam) |
Description
•