Closed Bug 1728269 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30252 - [wave] Use the correct part of uri for the reporturl api

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox95 fixed)

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30252 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30252
Details from upstream follow.

b'Roger Johannesson <rogerj@vewd.com>' wrote:

[wave] Use the correct part of uri for the reporturl api

uri_parts[3] is the function "reporturl" in this case, the
api is the part before that.

This fix targets the comparison view in the wave UI. Without this
fix wave won't even try to make a comparison since it will use
"reporturl" as identifier for the test group. It should be "acid"
for the "acid" test group etc.

However, note that the comparison view depends on a specific
version of wptreport to function properly, namely
https://github.com/fraunhoferfokus/wptreport

The reason is that it uses the --tokenFileName command line
flag which is only available in that version of wptreport at the
time of preparing this patch.

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/997c99b9f84b
[wpt PR 30252] - [wave] Use the correct part of uri for the reporturl api, a=testonly
Test result changes from PR not available.
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b08d1e7734bd
[wpt PR 30252] - [wave] Use the correct part of uri for the reporturl api, a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.