172833 - need support for a conditional interface map entry

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Darin Fisher]

there's a number of conditional QI's out there that sort of take advantage of
the QI macros.  for example,

http://lxr.mozilla.org/seamonkey/source/netwerk/base/src/nsStandardURL.cpp#803
http://lxr.mozilla.org/seamonkey/source/netwerk/protocol/viewsource/src/nsViewSourceChannel.cpp#53

it probably makes sense to come up with a macro for this.  how about
NS_INTERFACE_MAP_ENTRY_CONDITIONAL or NS_INTERFACE_MAP_CONDITIONAL_ENTRY?

Comment 1

[Doug Turner (:dougt)]

Attachment: proposed patch v.1

yeah, I think it is a good idea.

Comment 2

[Doug Turner (:dougt)]

hmm.  Condition first.  new patch coming up.

Comment 3

[Doug Turner (:dougt)]

Attachment: number 2

Comment 4

[Boris Zbarsky [:bzbarsky]]

> +    NS_INTERFACE_MAP_ENTRY_CONDITIONAL(nsIURL, mSupportsFileURL)

nsIFileURL you mean?

Also, could you thwack nsViewSourceChannel too, while you're doing this?

Comment 5

[Doug Turner (:dougt)]

Attachment: three three three

Just checking to see if you were awake! :-)

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 102016 [details] [diff] [review]
three three three

r/sr=bzbarsky.	Being awake is overrated.  ;)

Comment 7

[Doug Turner (:dougt)]

especially when the reviewers are awake!  thanks.

Comment 8

[Darin Fisher]

Comment on attachment 102016 [details] [diff] [review]
three three three

>     // see nsStandardURL::Equals
>     if (aIID.Equals(kThisImplCID))
>         foundInterface = NS_STATIC_CAST(nsIURI *, this);
>     else
> NS_INTERFACE_MAP_END

grr... so i guess it doesn't solve this one.  oh well :(

r/sr=darin

Comment 9

[Doug Turner (:dougt)]

Checking in xpcom/glue/nsISupportsImpl.h;
/cvsroot/mozilla/xpcom/glue/nsISupportsImpl.h,v  <--  nsISupportsImpl.h
new revision: 3.18; previous revision: 3.17
done
Checking in netwerk/base/src/nsStandardURL.cpp;
/cvsroot/mozilla/netwerk/base/src/nsStandardURL.cpp,v  <--  nsStandardURL.cpp
new revision: 1.39; previous revision: 1.38
done
Checking in netwerk/protocol/viewsource/src/nsViewSourceChannel.cpp;
/cvsroot/mozilla/netwerk/protocol/viewsource/src/nsViewSourceChannel.cpp,v  <--
 nsViewSourceChannel.cpp
new revision: 1.15; previous revision: 1.14
done

thanks