1728339 - .dmg detection does not work

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Markus Stange [:mstange]]

The detection from bug 516362 works in local builds (in the dmg produced by ./mach package), but it does not seem to work in official "Firefox Nightly.app" builds. And it doesn't appear to work on try builds either.

STR:

1. Download Nightly.
2. Open the .dmg
3. Double click the "Firefox Nightly" icon in the .dmg folder.

Expected results:
There should be a modal dialog prompting you to install.

Actual results:
A regular Firefox window opens.

Comment 1

[Markus Stange [:mstange]]

The detection seems to work correctly when the build is launched from the command line.

Comment 2

[Markus Stange [:mstange]]

I made a try build with lots of logging.

When double-clicked in the dmg (or actually right clicked + "Open", because it's unsigned) it logs that statfsBuf.f_mntfromname is /Volumes/Firefox Nightly 2/Firefox Nightly.app.
This is surprising. It's expected to be something of the form /dev/diskXsY.

To see the logging from the try build, open Console.app, start streaming, and filter for processes with the name firefox.

Comment 3

[Markus Stange [:mstange]]

It looks like this might only happen under App Translocation. I've only seen it in builds from dmgs which have the quarantine bit set.

I made another try build which tries to call statfs again, and that seems to be a possible workaround:
Bundle path: /private/var/folders/96/nv6fx_mx75jg7tm4rwmlzfnh0000gn/T/AppTranslocation/D660235B-EBE2-448E-A9F2-773FFE4DCE11/d/Firefox Nightly.app
f_mntfromname: /Volumes/Firefox Nightly 4/Firefox Nightly.app
Then, after calling statfs on /Volumes/Firefox Nightly 4/Firefox Nightly.app:
f_mntfromname: /dev/disk8s3

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1728339 - Find the mount point BSD name correctly even under App Translocation, by calling statfs a second time. r=spohl

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d0f2c12cfd5
Find the mount point BSD name correctly even under App Translocation, by calling statfs a second time. r=spohl

Comment 6

[Markus Stange [:mstange]]

I'm setting 92 to "affected" because this bug means that the telemetry from bug 1700795 (which is in 92) doesn't work. That's harmless. But we need to be aware of it when looking at the telemetry data, or maybe uplift this patch to 92.

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/8d0f2c12cfd5

Comment 8

[Markus Stange [:mstange]]

Comment on attachment 9238795 [details]
Bug 1728339 - Find the mount point BSD name correctly even under App Translocation, by calling statfs a second time. r=spohl

Beta/Release Uplift Approval Request

• User impact if declined: Telemetry from bug 1700795 will be useless
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very low risk patch to a code path which only runs when Firefox is launched from a read-only directory (which in >99% of cases will be from inside a mounted dmg).
• String changes made/needed:

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9238795 [details]
Bug 1728339 - Find the mount point BSD name correctly even under App Translocation, by calling statfs a second time. r=spohl

Approved for 92.0rc2.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/3049159544ae