Closed Bug 1728388 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30261 - FS: Add check for removal of sandbox root dir

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox94 fixed)

Status:
RESOLVED FIXED
Milestone:
94 Branch
Tracking Flags:
Tracking Status
firefox94 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30261 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30261
Details from upstream follow.

b'Austin Sullivan <asully@chromium.org>' wrote:

FS: Add check for removal of sandbox root dir

The FileSystemHandle::Remove() method was recently added to allow for
the removal of files and directories from the underlying file system.

This method now fails when attempting to delete the root of a sandbox
file system.

Bug: 1242231
Change-Id: Ibe3ed59b79678ce168d0803c6607abd8ac06594c
Reviewed-on: https://chromium-review.googlesource.com/3123735
WPT-Export-Revision: fdad169e64324495deb28f89090cdf20e2b02a93

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 8 subtests

Status Summary

Firefox

OK : 2
FAIL: 16

Chrome

OK : 2
PASS: 14
FAIL: 2

Safari

OK : 2
FAIL: 16

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/file-system-access/sandboxed_FileSystemBaseHandle-remove.https.any.html
remove() to remove a file: FAIL (Chrome: PASS, Safari: FAIL)
remove() on an already removed file should fail: FAIL (Chrome: PASS, Safari: FAIL)
remove() to remove an empty directory: FAIL (Chrome: PASS, Safari: FAIL)
remove() on an already removed directory should fail: FAIL (Chrome: PASS, Safari: FAIL)
remove() on a non-empty directory should fail: FAIL (Chrome: PASS, Safari: FAIL)
remove() on a directory recursively should delete all sub-items: FAIL (Chrome: PASS, Safari: FAIL)
remove() on a file should ignore the recursive option: FAIL (Chrome: PASS, Safari: FAIL)
cannot remove the root of a sandbox file system: FAIL (Chrome: FAIL, Safari: FAIL)
/file-system-access/sandboxed_FileSystemBaseHandle-remove.https.any.worker.html
remove() to remove a file: FAIL (Chrome: PASS, Safari: FAIL)
remove() on an already removed file should fail: FAIL (Chrome: PASS, Safari: FAIL)
remove() to remove an empty directory: FAIL (Chrome: PASS, Safari: FAIL)
remove() on an already removed directory should fail: FAIL (Chrome: PASS, Safari: FAIL)
remove() on a non-empty directory should fail: FAIL (Chrome: PASS, Safari: FAIL)
remove() on a directory recursively should delete all sub-items: FAIL (Chrome: PASS, Safari: FAIL)
remove() on a file should ignore the recursive option: FAIL (Chrome: PASS, Safari: FAIL)
cannot remove the root of a sandbox file system: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/70637db68ab5
[wpt PR 30261] - FS: Add check for removal of sandbox root dir, a=testonly
https://hg.mozilla.org/integration/autoland/rev/9e9cd760423f
[wpt PR 30261] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/70637db68ab5
https://hg.mozilla.org/mozilla-central/rev/9e9cd760423f

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox94: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.